Skip to content

V13#201

Merged
rwmcintosh merged 9 commits into
developfrom
v13
Jul 16, 2026
Merged

V13#201
rwmcintosh merged 9 commits into
developfrom
v13

Conversation

@rwmcintosh

@rwmcintosh rwmcintosh commented Jul 16, 2026

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • New Features

    • Updated installer and application packaging for the 13.0 release series.
    • The installer now includes the Windows Desktop Runtime 10.0.10 (x64).
  • Build & Distribution

    • Retargeted build workflows to the 13.0 nightly line and updated artifact retrieval.
    • Refreshed build tooling versions used during installer and dependency packaging.
  • Documentation

    • Updated README build status badges to point to the latest 13.0 workflows.
    • Refreshed the unit and integration test reference link for OSPSuite.FuncParser.

- bundle.wxs + workflow downloads: .NET 8 desktop runtime 8.0.20 -> .NET 10 (10.0.10)
- build-and-publish/build-PR: APP_VERSION 12.3 -> 13.0
- pull component installers from the 13.0 nightlies (PK-Sim/MoBi build-nightly_v13,
  InstallationValidator build-nightly_13.0) instead of build-nightly_12.3
- bump actions: checkout@v6, upload-artifact@v7, download-artifact@v8
- README: point nightly-status badge links at the renamed component workflows
@coderabbitai

coderabbitai Bot commented Jul 16, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@rwmcintosh, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 22 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 882e15e1-0cda-434f-bb60-92cdae4026e8

📥 Commits

Reviewing files that changed from the base of the PR and between 228ae98 and c3dda81.

📒 Files selected for processing (1)
  • validation and qualification/README.md
📝 Walkthrough

Walkthrough

The release configuration moves PK-Sim and MoBi from the 12.3 series to 13.0, updates nightly artifact workflows and badges, upgrades GitHub Actions, and replaces the .NET Framework prerequisite with the Windows Desktop .NET 10 runtime.

Changes

Release and installer transition

Layer / File(s) Summary
Versioning and nightly artifact wiring
.github/workflows/build-PR.yml, .github/workflows/build-and-publish_v13.yml, versions.json, versions.xml, README.md, validation and qualification/README.md
Updates application and workflow versions to 13.0, retargets PK-Sim, MoBi, and InstallationValidator artifact sources, refreshes status badges, and updates the FuncParser artifact link.
Installer runtime and action updates
.github/workflows/build-PR.yml, .github/workflows/build-and-publish_v13.yml, setup/bundle.wxs
Upgrades checkout, artifact download, and upload actions, and switches the installer prerequisite to Windows Desktop Runtime 10.0.10 x64.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

Suggested reviewers: yuri05

Poem

A rabbit hops through builds anew,
With thirteen bright in every queue.
Old runtimes rest beneath the sun,
While desktop ten begins to run.
Artifacts bound, the badges gleam—
A carrot-powered release dream.

🚥 Pre-merge checks | ✅ 3 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title is too vague and does not describe the actual workflow, installer, and version updates in the change set. Use a concise descriptive title such as "Bump build workflows and installer assets to v13".
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch v13

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

…ly 13.0

Renaming the workflow file resets github.run_number so the 13.0 line starts fresh
instead of continuing the 12.3 counter. Update the README Suite Setup badge links.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
README.md (1)

79-79: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low value

Consider updating the badge image URLs to match the workflow links.

The status badges for PK-Sim, MoBi, Installation Validator, and Qualification Runner use nightly-badge.yml for their image URLs, but the hyperlink targets point to the newly named workflows (e.g., build-nightly_v13.yml). Unless nightly-badge.yml is maintained specifically as a static endpoint for status badges, you might want to update the image URLs to reference the actual workflows being tracked.

💡 Proposed optional fix for badge image URLs
-[![Setup status](https://img.shields.io/github/actions/workflow/status/Open-Systems-Pharmacology/Suite/build-and-publish_v13.yml?logo=GitHub&label=Suite%20Setup)](https://github.com/Open-Systems-Pharmacology/Suite/actions/workflows/build-and-publish_v13.yml)  [![PK-Sim status](https://img.shields.io/github/actions/workflow/status/Open-Systems-Pharmacology/PK-Sim/nightly-badge.yml?logo=GitHub&label=PK-Sim)](https://github.com/Open-Systems-Pharmacology/PK-Sim/actions/workflows/build-nightly_v13.yml)  [![MoBi status](https://img.shields.io/github/actions/workflow/status/Open-Systems-Pharmacology/MoBi/nightly-badge.yml?logo=GitHub&label=MoBi)](https://github.com/Open-Systems-Pharmacology/MoBi/actions/workflows/build-nightly_v13.yml)  [![Installation Validator status](https://img.shields.io/github/actions/workflow/status/Open-Systems-Pharmacology/InstallationValidator/nightly-badge.yml?logo=GitHub&label=Installation%20Validator)](https://github.com/Open-Systems-Pharmacology/InstallationValidator/actions/workflows/build-nightly_13.0.yml)  [![Qualification Runner status](https://img.shields.io/github/actions/workflow/status/Open-Systems-Pharmacology/QualificationRunner/nightly-badge.yml?logo=GitHub&label=Qualification%20Runner)](https://github.com/Open-Systems-Pharmacology/QualificationRunner/actions/workflows/build-nightly_13.0.yml)
+[![Setup status](https://img.shields.io/github/actions/workflow/status/Open-Systems-Pharmacology/Suite/build-and-publish_v13.yml?logo=GitHub&label=Suite%20Setup)](https://github.com/Open-Systems-Pharmacology/Suite/actions/workflows/build-and-publish_v13.yml)  [![PK-Sim status](https://img.shields.io/github/actions/workflow/status/Open-Systems-Pharmacology/PK-Sim/build-nightly_v13.yml?logo=GitHub&label=PK-Sim)](https://github.com/Open-Systems-Pharmacology/PK-Sim/actions/workflows/build-nightly_v13.yml)  [![MoBi status](https://img.shields.io/github/actions/workflow/status/Open-Systems-Pharmacology/MoBi/build-nightly_v13.yml?logo=GitHub&label=MoBi)](https://github.com/Open-Systems-Pharmacology/MoBi/actions/workflows/build-nightly_v13.yml)  [![Installation Validator status](https://img.shields.io/github/actions/workflow/status/Open-Systems-Pharmacology/InstallationValidator/build-nightly_13.0.yml?logo=GitHub&label=Installation%20Validator)](https://github.com/Open-Systems-Pharmacology/InstallationValidator/actions/workflows/build-nightly_13.0.yml)  [![Qualification Runner status](https://img.shields.io/github/actions/workflow/status/Open-Systems-Pharmacology/QualificationRunner/build-nightly_13.0.yml?logo=GitHub&label=Qualification%20Runner)](https://github.com/Open-Systems-Pharmacology/QualificationRunner/actions/workflows/build-nightly_13.0.yml)
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@README.md` at line 79, Update the README status badge image URLs for PK-Sim,
MoBi, Installation Validator, and Qualification Runner to reference the same
workflow filenames used by their hyperlink targets, including the v13 naming.
Leave the badge labels and workflow links unchanged.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@README.md`:
- Line 79: Update the README status badge image URLs for PK-Sim, MoBi,
Installation Validator, and Qualification Runner to reference the same workflow
filenames used by their hyperlink targets, including the v13 naming. Leave the
badge labels and workflow links unchanged.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: b612c74e-429c-4b38-a198-201335b42a26

📥 Commits

Reviewing files that changed from the base of the PR and between 1ac316a and 0dbe495.

📒 Files selected for processing (6)
  • .github/workflows/build-PR.yml
  • .github/workflows/build-and-publish_v13.yml
  • README.md
  • setup/bundle.wxs
  • versions.json
  • versions.xml

@rwmcintosh rwmcintosh closed this Jul 16, 2026
@rwmcintosh rwmcintosh reopened this Jul 16, 2026
The linked FuncParser Actions run (16811208145) was a .NET 8-era build and is
now gone (404). Point it at run 25451594842, which built FuncParser 5.0.0.3 -
the version bundled on the .NET 10 / 13.0 line.
The linked run (16832845482) was an Aug 2025 .NET 8-era build; update it to run
25508815268, which built SimModel 5.0.0.76 - the version bundled on the .NET 10 /
13.0 line.
@rwmcintosh
rwmcintosh requested a review from Yuri05 July 16, 2026 17:59
@rwmcintosh rwmcintosh self-assigned this Jul 16, 2026
@rwmcintosh
rwmcintosh merged commit 7b54897 into develop Jul 16, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants