fix: use identity checks for type comparisons; remove mutable default argument - #2277
Open
harshadkhetpal wants to merge 1 commit into
Open
Conversation
… argument Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Signed-off-by: Harshad Khetpal <harshadkhetpal@users.noreply.github.com>
Contributor
|
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
opencontractserver/llms/tools/tool_factory.py— the annotation→JSON-schema dispatch chain compares type objects with==five times (param.annotation == int,float,bool,list,dict) — ruff E721. Identity (is) is the intended semantics for type objects and avoids surprises with metaclass-defined__eq__.opencontractserver/pipeline/utils.py—run_post_processors(..., input_kwargs: dict[str, Any] = {})shares one dict across every call (ruff B006). Changed to theNonesentinel withinput_kwargs = input_kwargs or {}after the docstring; identical behavior for all callers.Testing
python -m py_compilepasses on both files;ruff check --select B006,E721on them goes clean.🤖 Generated with Claude Code