docs: fix six broken links across docs and frontend README - #2255
Merged
Conversation
Each fix verified against the tree or with a live request: - step-8-data-extract.md: one ../ too many on the LLM framework link - agent_corpus_actions_design.md: ../llms/README.md resolved outside docs/architecture, where llms/ actually lives - auth_flow.md: one ../ too few to reach frontend/src/docs/ - websocket/frontend.md: ChatSourceAtom is .tsx, not .ts - frontend/README.md: Create React App docs moved from facebook.github.io/create-react-app to create-react-app.dev (both 404) - frontend-configuration.md: frontend/public/env-config.js is gitignored and generated at container start, so a blob/main link can never resolve; point at frontend/env.sh, which generates it
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
Contributor
Author
|
recheck |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Six broken links, each verified against the tree or with a live HTTP request. Docs only — no code changes.
docs/walkthrough/step-8-data-extract.md../../architecture/llms/README.md— one../too many../architecture/llms/README.mddocs/architecture/agent_corpus_actions_design.md../llms/README.mdresolved todocs/llms/, butllms/is insidedocs/architecture/llms/README.mddocs/frontend/auth_flow.md../frontend/src/docs/AUTHENTICATION_PATTERN.md— one../too few../../frontend/src/docs/…docs/architecture/websocket/frontend.mdChatSourceAtom.ts— the file is.tsxChatSourceAtom.tsxfrontend/README.md(×2)facebook.github.io/create-react-app(both links 404)create-react-app.dev/docs/…docs/configuration/frontend-configuration.mdblob/main/frontend/public/env-config.js, but that file is gitignored and generated at container start — the link can never resolvefrontend/env.sh, the script that generates itDeliberately left alone
Two clusters of broken links need a maintainer's call, so I didn't guess:
config/graphql/{graphene_types,mutations,queries}.py— referenced fromagent_corpus_actions_design.md,commenting_system/*.md,social-media-previews.md, anddual_tree_implementation_plan.md. Those monolithic modules were split into per-domain files (agent_types.py,agent_mutations.py,corpus_queries.py, …), so each reference needs repointing to the right one — an editorial decision, not a mechanical one.docs/architecture/apollo_cache.md— linked fromauth_flow.md:301, but no such file exists anywhere in the repo. Either it was never written or it moved under a different name.Happy to follow up on either if you tell me where they should point.