refactor(go): remove unused settings - #60
Merged
Merged
Conversation
BREAKING CHANGE: BLE Config no longer exposes or accepts dev_name, and the full snapshot contains 17 keys.
BREAKING CHANGE: BLE Config no longer exposes or accepts inact_to, and the full snapshot contains 16 keys.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove the unused AirGradient Go device name and inactivity timeout settings. The runtime auto-lock setting remains unchanged.
Changes
device_nameandinactivity_timeout_secondsfrom Go settings and NVS persistencedev_nameandinact_tofrom the unreleased BLE Config schema, reducing it from 18 to 16 keysValidation