Repository navigation
fix: keep the detected extension on URL job file names - #499
Open
RaphaelFakhri wants to merge 1 commit into
Open
RaphaelFakhri wants to merge 1 commit into
RaphaelFakhri wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_resolve_url_source_file_namenow keeps the requestfile_nameonly when its extension matches the extension detected for the URL. Otherwise it appends the detected extension, the same way the URL basename path already does. For example,annual-report.docxon a URL that serves a PDF becomesannual-report.docx.pdf.source_file_nameextension, so a v2 URL job for a PDF withfile_name="annual-report.docx"was accepted and then failed innormalize_to_pdfwithpage_memory parse track only supports PDF and PPTX.hipo-upload-optimization_a884bd1b.plan.mdon an.mdURL, are unchanged. The comparison ignores case, soReport.PDFis kept.file_namewith a different extension breaks the page-memory parse #498Verification
uv run pytest apps/api/tests/unit/test_document_ingestion_filename.py -q: 6 passed. With the source change reverted, the new mismatch test fails (1 failed, 5 passed).ruff checkon the changed files: passed.Deployment Notes
source_file_name.Checklist