Skip to content

fix: retain complete DOCX asset paths and initial sync progress - #146

Merged
suguanYang merged 1 commit into
mainfrom
codex/wangbinqi/docx-reference-paths
Nov 2, 2026
Merged

suguanYang merged 1 commit into
mainfrom
codex/wangbinqi/docx-reference-paths

Conversation

@suguanYang

Copy link
Copy Markdown
Contributor

Summary

 collectReferences(content)
-  stop at the first bracket or parenthesis
+  preserve balanced delimiters inside asset names
 syncArchive()
+  persist the pinned archive identity before starting the first entry

DOCX image names such as images/image-[1] Generated.png previously produced a nonexistent images/image-[1 reference and prevented final snapshot publication. Preserve the full path without relaxing missing-origin or integrity checks. Persist a zero-entry checkpoint before copying a large first resource so a deadline retains the immutable generation for the next invocation.

Evidence

  • Before: New public snapshot tests failed with missing origins for bracketed image names and parenthesized Markdown targets; the first-entry deadline test had no persisted checkpoint.
    After: 587 tests pass across 28 files, including all four delimiter regressions and first-entry deadline/resume. TypeScript, ESLint, Prettier, and diff checks pass.
  • Manual diff and surrounding-code review found no actionable issues. Existing negative integrity, cancellation, lease, and checkpoint failure tests remain passing.
  • Production DOCX reacceptance is pending SDK publication and Hipo deployment; this PR does not claim live acceptance.

Merge Danger

Door: two-way

Blast Radius: snapshots

Immutable archive identities and content hashes remain mandatory. The additional initial checkpoint has no copied entries and is never a completed commit.

@suguanYang
suguanYang merged commit 4f92970 into main Nov 2, 2026
4 checks passed
@github-actions github-actions Bot mentioned this pull request Nov 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant