Repository navigation
fix: checkpoint archive segments at deadlines and validate repeated resources - #144
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A segment could remain inside an active transfer after its configured budget. The reported result ZIP also contained a repeated resource with identical bytes.
Preserve the original directory identity for existing checkpoints. Conflicting duplicate paths fail before uploads; checkpoint persistence failure and caller cancellation remain failures. Immutable snapshot verification deduplicates resource hashes while checking every physical ZIP entry's CRC and size and the complete archive SHA-256. Includes a patch changeset.
Evidence
After: Deadline handoff saves the contiguous prefix and resumes without rewriting that prefix; checkpoint failure is propagated; identical repeated resources complete and conflicting bytes fail before uploads. Immutable snapshot checksum verification passes with and without the archive cache, including rereading a completed snapshot.
Merge Danger
Door: two-way
No migration. Original archive identity is retained for prefixes saved before a repeated entry. SDK publication is separate from the Hipo Web/API rollout.
Blast Radius: synchronization