Skip to content

Fix return static 1 bug #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ruien0412 merged 1 commit into from
Nov 1, 2025
Merged

Fix return static 1 bug #60

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions sandbox/runHandler.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -338,6 +338,14 @@ func (s *Sandbox) runExecute(box int, ctx context.Context, qt models.QuestionTes
out, err := cmd.CombinedOutput()
if err != nil {
outStr := string(out)
if strings.Contains(outStr, "Exited with error status 1") {
result.Status = "SUCCESS" // 整體執行成功
result.Result = "⚠️ GTest 測試未全數通過，請檢查 JSON 結果。"
results = append(results, result)
continue
}

// ✅ 再檢查是否為 core dumped / Segfault 類型
hasCore := strings.Contains(outStr, "core dumped") ||
strings.Contains(outStr, "Illegal instruction") ||
strings.Contains(outStr, "Segmentation fault") ||
Expand All @@ -348,7 +356,8 @@ func (s *Sandbox) runExecute(box int, ctx context.Context, qt models.QuestionTes
if hasCore && hasExit {
// 提取 exit code
exitLine := regexp.MustCompile(`Exited with error status [0-9]+`).FindString(outStr)
result.Result = "Illegal instruction (core dumped)\n" + exitLine + "\n請檢查程式中是否有使用未初始化指標、陣列越界、或動態記憶體錯誤等行為。"
result.Result = "Illegal instruction (core dumped)\n" + exitLine +
"\n請檢查程式中是否有使用未初始化指標、陣列越界、或動態記憶體錯誤等行為。"
result.Status = string(RUNTIME_ERROR)
} else {
result.Result = outStr
Expand Down Expand Up @@ -461,7 +470,7 @@ func (s *Sandbox) mergeCompileAndExecuteResult(
finalResults = append(finalResults, SandboxJudgeResult{
Target: e.Target,
Status: "SUCCESS",
Result: "Compile amd Execute success, ready for scoring.",
Result: "Compile and Execute success, ready for scoring.",
})
} else {
// 任一失敗
Expand Down