Skip to content

fix(ci): publish the Helm chart only after the image #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TheMeinerLP wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(ci): publish the Helm chart only after the image #181

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion .github/workflows/release-please.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,12 @@ jobs:
# needs no chart of its own.
helm:
name: Publish the Helm chart
needs: release-please
# Also on `docker`, not just on the release: the chart is packaged with the
# release version as its appVersion, so pushing it before the image exists
# publishes a chart that points at a tag nobody can pull yet - and leaves
# one published for good if the image build fails. `needs` implies success,
# so a skipped or failed docker job skips the chart too.
needs: [release-please, docker]
if: needs.release-please.outputs.release_created == 'true'
runs-on: ubuntu-latest
permissions:
Expand Down
Loading