Skip to content

fix(item): separate reorder handling from lore dto - #167

Merged
theEvilReaper merged 5 commits into
mainfrom
feature/lore-reorder
Aug 22, 2026
Merged

fix(item): separate reorder handling from lore dto#167
theEvilReaper merged 5 commits into
mainfrom
feature/lore-reorder

Conversation

@theEvilReaper

@theEvilReaper theEvilReaper commented Aug 22, 2026

Copy link
Copy Markdown
Contributor

Proposed changes

At the moment, the lore reorder logic is tightly coupled with the regular lore DTO handling. This makes it harder to maintain and increases the likelihood of producing invalid results. This pull request separates both concerns into different contexts.

Types of changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of
them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before
merging your code.

  • I have read the CONTRIBUTING.md
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@theEvilReaper theEvilReaper self-assigned this Aug 22, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Test results

 27 files   27 suites   3s ⏱️
 53 tests  41 ✅ 12 💤 0 ❌
159 runs  123 ✅ 36 💤 0 ❌

Results for commit 7d98cb2.

@theEvilReaper
theEvilReaper merged commit 2d05d22 into main Aug 22, 2026
8 checks passed
@theEvilReaper
theEvilReaper deleted the feature/lore-reorder branch August 22, 2026 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant