feat: add market theme token previews ｜OK-61996 - #13226
Conversation
|
@codex review |
|
@codex security review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Swish! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Security review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
| <NumberSizeableText | ||
| size="$bodyMdMedium" | ||
| formatter="priceChange" | ||
| formatterOptions={{ showPlusMinusSigns: true }} |
There was a problem hiding this comment.
Zero changes look positive
Severity: non-severe
With a zero 24-hour change, showPlusMinusSigns formats the neutral value as +0%. The shared formatter adds + to zero when enabled (formatDisplayNumber).
Suggested fix:
formatterOptions={{ showPlusMinusSigns: numericChange > 0 }}![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| <TradingViewDesktopToolbarContext.Provider value={proToolbar}> | ||
| <Stack flex={1} minWidth={0} overflow="hidden"> | ||
| {marketTradingView} | ||
| </Stack> |
There was a problem hiding this comment.
Unavailable Pro chart traps users
Severity: non-severe
When Pro chart data is unavailable, TradingViewDesktopToolbarContext.Provider renders the mode control only through the missing chart. Persisted Pro-mode users see an empty panel and cannot return to Simple mode.
9330eae to
434a745
Compare
2 participants
OK-61996
Summary
Updates Market theme banners to display token previews, making prices and 24h performance visible directly on the Market homepage.
Related issue: OK-61996
Base branch:
xChanges
Theme banner cards
--.API integration and refresh
tokensfield to the banner response model.tokens.Loading states and test coverage
Validation
yarn agent:check --profile commitpassed, including lint, formatting, TypeScript, and background API contract checks.--.Backend dependency
The current backend implementation returns the first three tokens in the configured order. This change sorts those supplied previews, but the frontend cannot determine the top three gainers across the entire theme from an already truncated response.
To fully satisfy the theme-wide top-three-gainers requirement, the backend must sort the complete theme token list by 24h price change before selecting the three preview tokens.