Skip to content

feat: add Infini subscription deep link (OK-61658) - #13199

Open
yikZero wants to merge 25 commits into
OneKeyHQ:xfrom
yikZero:yikzero/prime-infini-deeplink-22fe
Open

feat: add Infini subscription deep link (OK-61658)#13199
yikZero wants to merge 25 commits into
OneKeyHQ:xfrom
yikZero:yikzero/prime-infini-deeplink-22fe

Conversation

@yikZero

@yikZero yikZero commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

OK-61658


OK-61658

Infini renewal emails and “return to merchant” links currently lead to the website instead of subscription management. This adds a dedicated web entry that opens the installed client and continues to the Infini management page after unlock and OneKey ID login.

Behavior

  • Production: https://app.onekey.so/prime/subscription
  • Test: https://app.onekeytest.com/prime/subscription
  • App scheme: onekey-wallet://prime_subscription
  • Prefer a supported OneKey extension and open its full-page tab through a first-party origin-gated bridge. Missing or unsupported extensions fall back to the App scheme; the landing retains manual open/download actions. Native fallback is offered only after the extension attempt fails; a pending extension request keeps the opening state.
  • Wait for the existing login flow to finish closing its dialog before continuing to subscription management. Login cancellation ends the handoff; an explicit Subscribe action takes priority over management.
  • Reuse existing login and subscription management. Accounts without an Infini record see a SearchDocument illustration, “No subscriptions to manage,” and “Only Prime subscriptions paid with crypto appear here.” Query failures retain the retry state.
  • Synchronize the two empty-state messages across all 19 locales through Lokalise.
  • Reuse the voucher landing page presentation for the header, loading state, and open/download actions. Each page keeps its existing launch flow; this removes duplicate UI and test scaffolding.

Validation

  • 12 Jest suites / 148 tests passed for landing-page launch/fallback, extension handoff, source permissions, deep-link routing, subscription management, URL construction, and native module IDs.
  • yarn agent:check --profile commit (lint, formatting, contracts, and TypeScript).
  • Native module registry checked against the latest upstream/x.
  • Desktop/iOS/Android: complete browser-to-installed-client flow, missing-token reauthentication, login cancellation, and navigation after dialog close.
  • Extension: first launch, an existing full-page tab, a slow background response, and continuation after unlock/login in a real browser.
  • Empty/error/detail states and Chinese/English layout in light/dark mode; verify the shared presentation on both subscription and voucher landings.

Rollout

Deploy the matching web and client/extension versions and finish cross-platform validation before restoring the Infini return_url and renewal-email links on the server. Localhost extension testing requires a development extension.

@sidmorizon

Copy link
Copy Markdown
Contributor

@codex review

@sidmorizon

Copy link
Copy Markdown
Contributor

@codex security review

@sidmorizon

Copy link
Copy Markdown
Contributor

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 5, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-05T12:36:29.605410Z 75fea34 Manual request
🔒 Security Review Completed 2026-09-05T12:31:21.350042Z 75fea34 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Security review completed. No security issues were found in this pull request.

Reviewed commit: 75fea34e4a

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

  • You comment "@codex security review"
  • A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 75fea34e4a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread packages/kit/src/views/Prime/pages/PrimeDashboard/PrimeDashboard.tsx Outdated
Comment thread packages/kit/src/views/Prime/pages/PrimeDashboard/PrimeDashboard.tsx Outdated
Comment thread packages/kit/src/views/Prime/pages/PrimeDashboard/PrimeDashboard.tsx Outdated
Comment thread packages/kit/src/views/Prime/pages/PrimeDashboard/PrimeDashboard.tsx Outdated
Comment thread packages/kit/src/views/Prime/pages/PrimeDashboard/PrimeDashboard.tsx Outdated
Comment thread packages/kit/src/views/Prime/pages/PrimeDashboard/PrimeDashboard.tsx Outdated
@originalix

originalix commented Sep 7, 2026

Copy link
Copy Markdown
Collaborator

Automated review needs attention

Review of commit c0b246531810 finished, but some comments could not be published automatically.

Publication requires a retry or human review. This is not an automated approval.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants