Skip to content

Anthony/Continuation-For-PR#3917-Role-Change-Permissions-Confirmation-Modal#5340

Open
AnthonyWeathers wants to merge 1 commit into
developmentfrom
Anthony/Continuation-For-PR#3917-Role-Change-Permissions-Confirmation-Modal
Open

Anthony/Continuation-For-PR#3917-Role-Change-Permissions-Confirmation-Modal#5340
AnthonyWeathers wants to merge 1 commit into
developmentfrom
Anthony/Continuation-For-PR#3917-Role-Change-Permissions-Confirmation-Modal

Conversation

@AnthonyWeathers

Copy link
Copy Markdown
Contributor

Description

Took over the work of PR#3917, adjusting it according to feedback and added additional details to keep users aware of the changes they're making while utilizing the modal.

Related PRS (if any):

There is no backend related PR needed for this frontend one.

Main changes explained:

  • Delete file A for removing unused components …
  • Updated BasicInformationTab.jsx to import and use new file that contains the modal while passing in needed values to it
  • Created RoleChangePermissionsModal.jsx to allow admin/owner users to change the role of a user, while selecting which modified permissions to keep for the user, if any of the modified ones differ from the permissions of the user's new role.
  • Updated UserProfile.jsx to pass in a authUser object that is needed for the RoleChangePermissionsModal.jsx file

How to test:

  1. check into current branch
  2. do npm install and ... to run this PR locally
  3. Clear site data/cache
  4. log as admin or owner user (not sure if admin is high enough, would appreciate a check on that)
  5. go to dashboard→ Find a user (You can use Anthony Test or Anthony Test2 for testing)→ Go to this profile→ Click Manage Role & Permissions to open modal
  6. Change role of the user, and select any permissions that are listed, to keep for added/removed, then save.
  7. Verify a success toast is shown
  8. If you did not checkbox all of the listed permissions, then go to Permissions Management to check if a permission change log for the user, was created. (A change log would only occur, if there are permission changes on the role change, if you pick a role that happens to have no permissions displayed, or you check boxed all of the permissions shown, then likely no change log is created as there would be no change in the permission list of the user)
  9. verify this new feature works in [dark mode]

Screenshots or videos of changes:

Note:

In the modal, in dark mode specifically, some of the text is dark/black, I've tried looking into but can not figure out why, as in the styling, it has the value telling the text color to be #ffffff, but somehow something is overwriting it, and I do not see if when inspecting element and looking through the styling in each element possible.

Also, I'll be adding screenshots later, just making the PR currently.

…h feature and passed in auth object needed for endpoints
@netlify

netlify Bot commented Jun 12, 2026

Copy link
Copy Markdown

Deploy Preview for highestgoodnetwork-dev ready!

Name Link
🔨 Latest commit 44b54de
🔍 Latest deploy log https://app.netlify.com/projects/highestgoodnetwork-dev/deploys/6a2c8a2af496a30008072f4e
😎 Deploy Preview https://deploy-preview-5340--highestgoodnetwork-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant