Skip to content

Neeraj Fix LB Dashboard Wishlist Filtering And Navigation#5335

Open
Neeraj-Kondaveeti wants to merge 6 commits into
developmentfrom
Neeraj_Fix_Listing_Bidding_Village_Filter_Navigation
Open

Neeraj Fix LB Dashboard Wishlist Filtering And Navigation#5335
Neeraj-Kondaveeti wants to merge 6 commits into
developmentfrom
Neeraj_Fix_Listing_Bidding_Village_Filter_Navigation

Conversation

@Neeraj-Kondaveeti

@Neeraj-Kondaveeti Neeraj-Kondaveeti commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Description

image

Related PRS (if any):

This frontend PR is related to the Development Backend PR.

Main changes explained:

  • Replaced hardcoded village options with dynamically generated village values from wishlist data.
  • Added village selection callback support.
  • Added functional Go button behaviour to trigger filtering.
  • Added village filtering logic using selected village state.
  • Generated village dropdown options from actual wishlist data.

How to test:

  1. check into current branch
  2. do npm install and ... to run this PR locally
  3. Clear site data/cache
  4. log as admin user
  5. Navigate to : http://localhost:5173/lbdashboard/wishlists
  6. Verify village filtering:
    • Select a village from the dropdown.
    • Click Go.
  7. Confirm only matching properties are displayed.
  8. Verify navigation:
    • Click "Click for list overview".
    • Confirm navigation to:
      • /lbdashboard/wishlist/:id
    • Click "Click here to view availabilities".
    • Confirm navigation to:
      • /lbdashboard/wishlist/:id/availability
  9. Verify Chat with Host:
    • Confirm button is clickable.

Screenshots or videos of changes:

image image

Note:

- Existing wishlist functionality remains unchanged.
- Changes are isolated to Wishlist filtering, routing, and navigation behavior.

@netlify

netlify Bot commented Jun 9, 2026

Copy link
Copy Markdown

Deploy Preview for highestgoodnetwork-dev ready!

Name Link
🔨 Latest commit cf19158
🔍 Latest deploy log https://app.netlify.com/projects/highestgoodnetwork-dev/deploys/6a337299485649000870bfdf
😎 Deploy Preview https://deploy-preview-5335--highestgoodnetwork-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@Neeraj-Kondaveeti Neeraj-Kondaveeti added the High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible label Jun 9, 2026

@Mahitha-pasupuleti Mahitha-pasupuleti left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dropdown is working as intended.

Both links navigate to their respective destination pages successfully. However, the destination pages appear to have the same functionality and very similar UI, so there does not seem to be a noticeable difference between them.

The "Chat with Host" button is not working consistently across all pages. It is not clickable on some internal pages.

One suggestion: After selecting a village and navigating to one of the internal pages like "Click for list overview" or "Click here to view availabilities", clicking the browser back button takes the user to the main wishlist page which has "All Villages" instead of the chosen village. It may be worth reviewing the navigation flow to improve the user experience.
Screenshot 2026-06-11 at 1 03 23 PM
Screenshot 2026-06-11 at 1 02 58 PM
Screenshot 2026-06-11 at 1 02 38 PM

@Neeraj-Kondaveeti

Copy link
Copy Markdown
Contributor Author

The dropdown is working as intended.

Both links navigate to their respective destination pages successfully. However, the destination pages appear to have the same functionality and very similar UI, so there does not seem to be a noticeable difference between them.

The "Chat with Host" button is not working consistently across all pages. It is not clickable on some internal pages.

One suggestion: After selecting a village and navigating to one of the internal pages like "Click for list overview" or "Click here to view availabilities", clicking the browser back button takes the user to the main wishlist page which has "All Villages" instead of the chosen village. It may be worth reviewing the navigation flow to improve the user experience. Screenshot 2026-06-11 at 1 03 23 PM Screenshot 2026-06-11 at 1 02 58 PM Screenshot 2026-06-11 at 1 02 38 PM

Thanks for the review.

The scope of this task was to ensure the links navigate to their intended pages and that the "Chat with Host" button is clickable. Both have been implemented and verified.

The destination pages having similar UI/functionality and chat behavior on other pages are existing implementations outside the scope of this task. Could you please look into the changes and consider approving the PR?

@one-community

Copy link
Copy Markdown
Member

Reference in n

The dropdown is working as intended.
Both links navigate to their respective destination pages successfully. However, the destination pages appear to have the same functionality and very similar UI, so there does not seem to be a noticeable difference between them.
The "Chat with Host" button is not working consistently across all pages. It is not clickable on some internal pages.
One suggestion: After selecting a village and navigating to one of the internal pages like "Click for list overview" or "Click here to view availabilities", clicking the browser back button takes the user to the main wishlist page which has "All Villages" instead of the chosen village. It may be worth reviewing the navigation flow to improve the user experience. Screenshot 2026-06-11 at 1 03 23 PM Screenshot 2026-06-11 at 1 02 58 PM Screenshot 2026-06-11 at 1 02 38 PM

Thanks for the review.

The scope of this task was to ensure the links navigate to their intended pages and that the "Chat with Host" button is clickable. Both have been implemented and verified.

The destination pages having similar UI/functionality and chat behavior on other pages are existing implementations outside the scope of this task. Could you please look into the changes and consider approving the PR?

For this, and especially since you are trying to close out as quickly as possible, please write this up as a new task directly below your task for this PR. Drop me a picture of that on WhatsApp and I’ll assign fixing all this to someone else.

@Abhi-R0211 Abhi-R0211 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally on branch Neeraj_Fix_Listing_Bidding_Village_Filter_Navigation, and logged in as admin, here is my analysis:

What's Working Well

  • Village filter dropdown is populated dynamically from actual wishlist data — Earthbag Village, Cob Village options present
Image
  • Go button triggers filtering correctly — selecting Earthbag Village and clicking Go shows only Unit 405
Image
  • Click here to view availabilities navigates correctly to /lbdashboard/wishlist/:id/availability
Image
  • Click for list overview navigates correctly to /lbdashboard/wishlist/:id
Image

Issues

  1. Chat with Host — routes to 404
    Clicking Chat with Host on the main wishlists page navigates to /lbdashboard/wishlist/:id/chat, which returns a PAGE NOT FOUND error
Image
  1. Chat with Host on detail/availability page — non-functional
    On /lbdashboard/wishlist/:id/availability the Chat with Host button is clickable but does nothing. No navigation or action occurs on click.

  2. Back button does not retain village filter
    After selecting a village, clicking Go, and navigating into a detail page, pressing the browser back button resets the dropdown to All Villages instead of retaining the selected village.

  3. Theme inconsistency — navbar background in light mode
    In light mode the navbar renders with a yellow-green background while the rest of the page is dark, creating a visually inconsistent appearance

Image
  1. Theme inconsistency — dropdown in dark mode
    When opening the village dropdown in dark mode, the unselected area renders with a white background, conflicting with the dark theme
Image

@Neeraj-Kondaveeti

Copy link
Copy Markdown
Contributor Author

Tested locally on branch Neeraj_Fix_Listing_Bidding_Village_Filter_Navigation, and logged in as admin, here is my analysis:

What's Working Well

  • Village filter dropdown is populated dynamically from actual wishlist data — Earthbag Village, Cob Village options present
Image * Go button triggers filtering correctly — selecting Earthbag Village and clicking Go shows only Unit 405 Image * Click here to view availabilities navigates correctly to `/lbdashboard/wishlist/:id/availability` Image * Click for list overview navigates correctly to `/lbdashboard/wishlist/:id` Image **Issues**
  1. Chat with Host — routes to 404
    Clicking Chat with Host on the main wishlists page navigates to /lbdashboard/wishlist/:id/chat, which returns a PAGE NOT FOUND error
Image 2. **Chat with Host on detail/availability page — non-functional** On `/lbdashboard/wishlist/:id/availability` the Chat with Host button is clickable but does nothing. No navigation or action occurs on click. 3. **Back button does not retain village filter** After selecting a village, clicking Go, and navigating into a detail page, pressing the browser back button resets the dropdown to All Villages instead of retaining the selected village. 4. **Theme inconsistency — navbar background in light mode** In light mode the navbar renders with a yellow-green background while the rest of the page is dark, creating a visually inconsistent appearance Image 5. **Theme inconsistency — dropdown in dark mode** When opening the village dropdown in dark mode, the unselected area renders with a white background, conflicting with the dark theme Image

Hi Abhi,

Thank you for taking the time to review the PR.

I wanted to clarify that the issues mentioned in your review appear to be different from the requirements defined in the original task.

The task I picked up was focused on:

  • Fixing the village filter matching/filtering behavior.
  • Restoring Chat with Host button functionality (the button was previously not clickable).
  • Fixing the dropdown filtering behavior.
  • Correcting navigation for "Click here to view availabilities" and "Click for list overview".

Based on my testing, all of the above requirements are functioning as expected, and I included screenshots demonstrating each of these flows in the PR description.

Regarding the issues you identified:

  1. The Chat with Host button now functions and triggers navigation. The destination route returning a 404 appears to be a separate routing issue beyond the scope of this task.
  2. Chat with Host behavior on the availability/detail page was not part of the original requirements.
  3. Retaining the selected village after using the browser back button was not specified in the task acceptance criteria.
  4. The light mode / dark mode theme inconsistencies were also not included in the assigned scope.
  5. The light mode inconsistency is due to a different PR merge which is causing the issue which is unrelated to my PR.

I am happy to create or help investigate separate issues for these findings, as they seem like valid follow-up items. However, since the functionality requested in the original task has been completed and verified, would you mind revisiting the review and reconsidering approval of the PR?

Thank you for your time and feedback.

@Neeraj-Kondaveeti

Copy link
Copy Markdown
Contributor Author

Reference in n

The dropdown is working as intended.
Both links navigate to their respective destination pages successfully. However, the destination pages appear to have the same functionality and very similar UI, so there does not seem to be a noticeable difference between them.
The "Chat with Host" button is not working consistently across all pages. It is not clickable on some internal pages.
One suggestion: After selecting a village and navigating to one of the internal pages like "Click for list overview" or "Click here to view availabilities", clicking the browser back button takes the user to the main wishlist page which has "All Villages" instead of the chosen village. It may be worth reviewing the navigation flow to improve the user experience. Screenshot 2026-06-11 at 1 03 23 PM Screenshot 2026-06-11 at 1 02 58 PM Screenshot 2026-06-11 at 1 02 38 PM

Thanks for the review.
The scope of this task was to ensure the links navigate to their intended pages and that the "Chat with Host" button is clickable. Both have been implemented and verified.
The destination pages having similar UI/functionality and chat behavior on other pages are existing implementations outside the scope of this task. Could you please look into the changes and consider approving the PR?

For this, and especially since you are trying to close out as quickly as possible, please write this up as a new task directly below your task for this PR. Drop me a picture of that on WhatsApp and I’ll assign fixing all this to someone else.

Reference in n

The dropdown is working as intended.
Both links navigate to their respective destination pages successfully. However, the destination pages appear to have the same functionality and very similar UI, so there does not seem to be a noticeable difference between them.
The "Chat with Host" button is not working consistently across all pages. It is not clickable on some internal pages.
One suggestion: After selecting a village and navigating to one of the internal pages like "Click for list overview" or "Click here to view availabilities", clicking the browser back button takes the user to the main wishlist page which has "All Villages" instead of the chosen village. It may be worth reviewing the navigation flow to improve the user experience. Screenshot 2026-06-11 at 1 03 23 PM Screenshot 2026-06-11 at 1 02 58 PM Screenshot 2026-06-11 at 1 02 38 PM

Thanks for the review.
The scope of this task was to ensure the links navigate to their intended pages and that the "Chat with Host" button is clickable. Both have been implemented and verified.
The destination pages having similar UI/functionality and chat behavior on other pages are existing implementations outside the scope of this task. Could you please look into the changes and consider approving the PR?

For this, and especially since you are trying to close out as quickly as possible, please write this up as a new task directly below your task for this PR. Drop me a picture of that on WhatsApp and I’ll assign fixing all this to someone else.

Sure, I will do so.

Thank You !

@HemanthNidamanuru HemanthNidamanuru left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,

Tested this PR locally. Found the following issues:

  • Filter dropdown is not aligned in dark mode
  • "Click here to view availabilities" doesn't navigate to /lbdashboard/wishlist/:id/availability, it goes to /lbdashboard/listingshome instead
  • Chat with Host is clickable on the list page but results in a page not found error. On the individual village page, it is not clickable at all.
Image Image Image Image Image

@one-community

Copy link
Copy Markdown
Member

Reference in n

The dropdown is working as intended.
Both links navigate to their respective destination pages successfully. However, the destination pages appear to have the same functionality and very similar UI, so there does not seem to be a noticeable difference between them.
The "Chat with Host" button is not working consistently across all pages. It is not clickable on some internal pages.
One suggestion: After selecting a village and navigating to one of the internal pages like "Click for list overview" or "Click here to view availabilities", clicking the browser back button takes the user to the main wishlist page which has "All Villages" instead of the chosen village. It may be worth reviewing the navigation flow to improve the user experience. Screenshot 2026-06-11 at 1 03 23 PM Screenshot 2026-06-11 at 1 02 58 PM Screenshot 2026-06-11 at 1 02 38 PM

Thanks for the review.
The scope of this task was to ensure the links navigate to their intended pages and that the "Chat with Host" button is clickable. Both have been implemented and verified.
The destination pages having similar UI/functionality and chat behavior on other pages are existing implementations outside the scope of this task. Could you please look into the changes and consider approving the PR?

For this, and especially since you are trying to close out as quickly as possible, please write this up as a new task directly below your task for this PR. Drop me a picture of that on WhatsApp and I’ll assign fixing all this to someone else.

Reference in n

The dropdown is working as intended.
Both links navigate to their respective destination pages successfully. However, the destination pages appear to have the same functionality and very similar UI, so there does not seem to be a noticeable difference between them.
The "Chat with Host" button is not working consistently across all pages. It is not clickable on some internal pages.
One suggestion: After selecting a village and navigating to one of the internal pages like "Click for list overview" or "Click here to view availabilities", clicking the browser back button takes the user to the main wishlist page which has "All Villages" instead of the chosen village. It may be worth reviewing the navigation flow to improve the user experience. Screenshot 2026-06-11 at 1 03 23 PM Screenshot 2026-06-11 at 1 02 58 PM Screenshot 2026-06-11 at 1 02 38 PM

Thanks for the review.
The scope of this task was to ensure the links navigate to their intended pages and that the "Chat with Host" button is clickable. Both have been implemented and verified.
The destination pages having similar UI/functionality and chat behavior on other pages are existing implementations outside the scope of this task. Could you please look into the changes and consider approving the PR?

For this, and especially since you are trying to close out as quickly as possible, please write this up as a new task directly below your task for this PR. Drop me a picture of that on WhatsApp and I’ll assign fixing all this to someone else.

Sure, I will do so.

Thank You !

New bug posted here, thank you all: https://docs.google.com/document/d/1Jt_ulri6zaYq3KT6GKJzWmDlCVtVAdXSbaUlZWRtJBs/edit?tab=t.0#bookmark=id.boslaentzm6t

@Neeraj-Kondaveeti

Copy link
Copy Markdown
Contributor Author

Hi,

Tested this PR locally. Found the following issues:

  • Filter dropdown is not aligned in dark mode
  • "Click here to view availabilities" doesn't navigate to /lbdashboard/wishlist/:id/availability, it goes to /lbdashboard/listingshome instead
  • Chat with Host is clickable on the list page but results in a page not found error. On the individual village page, it is not clickable at all.

Image Image Image Image Image

Hi Hemanth, Thank you for taking the time to review this PR. I have made the changes addressing the issues. Can you please have a look again and let me know if everything works as intended.

Thank You !

@HemanthNidamanuru HemanthNidamanuru left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,

Retested this PR locally. Filter dropdown is still not aligned in dark mode, and "Click here to view availabilities" / "Click for list overview" navigate to different URLs but both point to the same page. Chat with Host is resolved.

Image Image Image Image Image

@sonarqubecloud

Copy link
Copy Markdown

@Neeraj-Kondaveeti

Copy link
Copy Markdown
Contributor Author

Hi,

Retested this PR locally. Filter dropdown is still not aligned in dark mode, and "Click here to view availabilities" / "Click for list overview" navigate to different URLs but both point to the same page. Chat with Host is resolved.

Image Image Image Image Image

Thanks for retesting.

I updated the dark-mode styling for the village filter dropdown so it aligns with the rest of the dark theme.

Regarding the availability and list overview links, they currently navigate to different routes as implemented in this PR. Both routes render the existing WishListItem component based on the current route configuration. Creating a separate availability page/view would require additional functionality beyond the navigation fixes included in this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants