Skip to content

Manoj - Add inventory navigation icons, cross-page links, and BM Dashboard dropdown under Other Links#5306

Open
ManojPuttaswamy wants to merge 26 commits into
developmentfrom
Manoj_BMDashboard
Open

Manoj - Add inventory navigation icons, cross-page links, and BM Dashboard dropdown under Other Links#5306
ManojPuttaswamy wants to merge 26 commits into
developmentfrom
Manoj_BMDashboard

Conversation

@ManojPuttaswamy

@ManojPuttaswamy ManojPuttaswamy commented May 30, 2026

Copy link
Copy Markdown
Contributor

Description

Screenshot 2026-03-27 at 10 51 01 AM

Related PRS (if any):

How to test:

  1. check into current branch
  2. do npm install and ... to run this PR locally
  3. Clear site data/cache
  4. log as admin user
  5. go to /bmdashboard
  6. verify bmdashboard header persistence under other links
  7. verify this new feature “All Inventory Types” under the BM projects dropdown
  8. verify navigation of each categories in “All Inventory Types” page
  9. verify back to all inventory type functionality from each category
  10. verify dropdown structure of BM Projects
  11. verify icons added for inventory types
  12. verify functionalities in dark mode

Screenshots or videos of changes:

REC-20260530200247.mp4

Notes:

@netlify

netlify Bot commented May 30, 2026

Copy link
Copy Markdown

Deploy Preview for highestgoodnetwork-dev ready!

Name Link
🔨 Latest commit a4c1644
🔍 Latest deploy log https://app.netlify.com/projects/highestgoodnetwork-dev/deploys/6a32dada9184740008ab7dfb
😎 Deploy Preview https://deploy-preview-5306--highestgoodnetwork-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@one-community one-community added the High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible label May 30, 2026

@DeepighaJ DeepighaJ left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Verified navigation to BM Dashboard through Other Links and confirmed the BM Dashboard header remains persistent after navigation as expected.
  • Verified the new "All Inventory Types" option is available under the BM Projects dropdown and navigates correctly.
  • Verified all inventory categories (Materials, Consumables, Equipments, Reusables, Tools, and Unit of Measurement) can be expanded and collapsed successfully.
  • Verified navigation from All Inventory Types to individual category pages and confirmed category data is displayed correctly.
  • Verified Back to All Inventory Types functionality works as expected from category pages.
  • Verified the updated BM Projects dropdown structure and inventory type icons are displayed correctly.

Issue Found
Dark Mode UI Inconsistency: When navigating back from category pages (e.g., Materials, Consumables) to All Inventory Types using the "All Inventory Types" button or icons, some table elements retain light-theme styling instead of adopting dark-mode colors. This results in reduced readability and an inconsistent user experience in Dark Mode. (Refer last screenshot.)
Image
Image
Image
Image
Image
Image
Image
Image
Image

@HemanthNidamanuru HemanthNidamanuru left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Manoj,

I tested this locally following the steps provided and found 2 issues:

Unit of Measurement is missing from the BM Projects dropdown.
Dark mode - The BM Projects dropdown has a slight misalignment in dark mode.

PR.5306.mp4

@amaresh2001 amaresh2001 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally on Manoj_BMDashboard.

Testing:

  • "BM Dashboard" is correctly listed under the Other Links dropdown
  • "All Inventory Types" appears in the BM Projects dropdown and routes correctly to /bmdashboard/inventorytypes
  • Dropdown closes after selecting an option
  • Categories (Materials, Consumables, Equipment, Reusables, Tools) are clickable navigation links with icons
  • "← All Inventory Types" back link is present on each category page

Issues:

  • Unit of Measurement is not a clickable link; all other categories on the Inventory Types page are clickable navigation links.
  • Dark mode inconsistency on navigation back when in dark mode and navigating from a category page back to /bmdashboard/inventorytypes, the page body renders with a white/light background while the navbar remains dark. The page does not fully apply dark mode styling on return navigation.
Image Image Image Image Image Image Image Image

@ManojPuttaswamy

Copy link
Copy Markdown
Contributor Author
  • Verified navigation to BM Dashboard through Other Links and confirmed the BM Dashboard header remains persistent after navigation as expected.
  • Verified the new "All Inventory Types" option is available under the BM Projects dropdown and navigates correctly.
  • Verified all inventory categories (Materials, Consumables, Equipments, Reusables, Tools, and Unit of Measurement) can be expanded and collapsed successfully.
  • Verified navigation from All Inventory Types to individual category pages and confirmed category data is displayed correctly.
  • Verified Back to All Inventory Types functionality works as expected from category pages.
  • Verified the updated BM Projects dropdown structure and inventory type icons are displayed correctly.

Issue Found Dark Mode UI Inconsistency: When navigating back from category pages (e.g., Materials, Consumables) to All Inventory Types using the "All Inventory Types" button or icons, some table elements retain light-theme styling instead of adopting dark-mode colors. This results in reduced readability and an inconsistent user experience in Dark Mode. (Refer last screenshot.) Image Image Image Image Image Image Image Image Image

Hi, Dark mode inconsistency has been fixed. Please re review it and Thankyou.

@ManojPuttaswamy

Copy link
Copy Markdown
Contributor Author

Tested locally on Manoj_BMDashboard.

Testing:

  • "BM Dashboard" is correctly listed under the Other Links dropdown
  • "All Inventory Types" appears in the BM Projects dropdown and routes correctly to /bmdashboard/inventorytypes
  • Dropdown closes after selecting an option
  • Categories (Materials, Consumables, Equipment, Reusables, Tools) are clickable navigation links with icons
  • "← All Inventory Types" back link is present on each category page

Issues:

  • Unit of Measurement is not a clickable link; all other categories on the Inventory Types page are clickable navigation links.
  • Dark mode inconsistency on navigation back when in dark mode and navigating from a category page back to /bmdashboard/inventorytypes, the page body renders with a white/light background while the navbar remains dark. The page does not fully apply dark mode styling on return navigation.

Image Image Image Image Image Image Image Image

Hi, the Issue 01 that you have mentioned, I believe Unit of Measurement is not supposed to be a clickable link. And, the second issue has been resolved. Please re review it. Thank you

@ManojPuttaswamy

Copy link
Copy Markdown
Contributor Author

Hi Manoj,

I tested this locally following the steps provided and found 2 issues:

Unit of Measurement is missing from the BM Projects dropdown. Dark mode - The BM Projects dropdown has a slight misalignment in dark mode.

PR.5306.mp4

Hi, The first issue, I believe that the unit of measurement is not a category and hence there is no navigation to it. The second issue has been resolved. Please re review it. Thankyou

@one-community

Copy link
Copy Markdown
Member

Hi Manoj,
I tested this locally following the steps provided and found 2 issues:
Unit of Measurement is missing from the BM Projects dropdown. Dark mode - The BM Projects dropdown has a slight misalignment in dark mode.
PR.5306.mp4

Hi, The first issue, I believe that the unit of measurement is not a category and hence there is no navigation to it. The second issue has been resolved. Please re review it. Thankyou

Text me when the unit of measure link is fixed too, so I can request re-review

@Mahitha-pasupuleti Mahitha-pasupuleti left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Manoj,

I reviewed and tested this PR. The BM Dashboard header persists correctly across navigation, and the new "All Inventory Types" feature is functioning as expected. Navigation between inventory categories works properly, and the back to All Inventory Types functionality returns users to the main inventory page without issues.

I also verified the BM Projects dropdown structure, inventory type icons, and overall navigation flow. All functionality works correctly in both light mode and dark mode.

Everything is working according to the requirements. Approving this PR.

Image Image Image Image Image

@Abhi-R0211 Abhi-R0211 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Manoj, I tested this PR locally across all navigation flows, dropdown behavior, and both light and dark modes. Here is my analysis:


What's Working Well

  • BM Dashboard is correctly listed under the Other Links dropdown and persists after navigation
  • "All Inventory Types" appears under BM Projects in the header and routes correctly to /bmdashboard/inventorytypes
Image
  • All inventory categories (Materials, Consumables, Equipment, Reusables, Tools, Unit of Measurement) are visible with icons on the All Inventory Types page
  • Dropdown closes after selecting an option
  • Dark mode is retained when navigating back from a category page to All Inventory Types - the previously reported white background issue appears fixed
  • BM Projects dropdown alignment in dark mode appears fixed
Image
  • Each category is a clickable navigation link and navigates to the correct page
  • The "All Inventory Types" back button is present on each category page and functions correctly
Image

Issues That Need To Be Addressed

1. Calendar Date Picker Misalignment in Dark Mode

The date/time picker on the All Inventory Types page (/bmdashboard/inventorytypes) has a slight misalignment in dark mode - the calendar popup is not properly anchored to the input field. Please fix the positioning so the picker aligns correctly with its input in dark mode.

Image

2. Highlighted Text Color in Light Mode

On the All Inventory Types page in light mode, the highlighted/selected category text color does not provide sufficient contrast. Please adjust the highlight color to ensure readability in light mode.

Image

@handikaharianto handikaharianto left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ManojPuttaswamy , I just reviewed the PR and here are my findings:

Good

bmdashboard header persistence under other links

Image

“All Inventory Types” under the BM projects dropdown

I can see that all icons are mapped consistently with their inventory types.
Image

dark/light modes work well

The layout is consistent across both dark/light modes.
Image
Image

Doubts

Materials -> Log Material page leads to not found page

This log material url leads to a not found page.
Image

Add Consumable page doesn't show up

When I clicked on Consumables -> Add Consumables, the url added /add but the page to add consumables doesn't show up.
Image

Inconsistency between the All Inventory Types page and dropdown

In the page, I can see that there is Unit of Measurement but it's not in the dropdown.
Image

BM Projects -> Issues page is not found.

I noticed that clicking on the Issues url redirected me to a not found page.
Image

UX improvement for navigating through the inventory types page.

Here, it's good that I can easily navigate through other inventory type pages, however, it might be better to add a tooltip when the user is hovering their mouse on the icon so that they know which inventory type it is.
Image

BM Projects dropdown disappears

I noticed that the BM Projects dropdown only appears after only selecting a project in the Building and Inventory Management Dashboard. Is this the expected behavior?
Image

@pixelpix13

Copy link
Copy Markdown

Hi @ManojPuttaswamy I reviewed the pr and following are my reviews:

BM Dashboard Navigation

Verified

  • BM Dashboard menu appears correctly under Other Links.
  • Header remains visible after navigation.
  • Refreshing the page works correctly.
  • Navigation away from and back to the page works correctly.
  • Browser back/forward navigation works as expected.
  • Dark mode and light mode both function properly.

Screenshot

image

Responsive Design

Issue

On mobile/smaller screen widths, text does not wrap properly and the page does not appear fully responsive.


All Inventory Types Navigation

Verified

  • "All Inventory Types" appears in the BM Projects dropdown.
  • Clicking the option routes correctly.
  • Dropdown closes after selection.

Screenshot

image

Inventory Categories

Verified

All inventory categories can be expanded/collapsed and are clickable:

  • Materials
  • Consumables
  • Equipment
  • Reusables
  • Tools
  • Unit of Measurement

Screenshot

image image image

Dark Mode

Verified

Dark mode styling appears to work correctly on the Inventory Types page.


BM Projects Dropdown

Verified

BM Projects dropdown displays the expected links and navigation works correctly.

Screenshot

image

Date Filter

Issue

The date filter appears to have no visible effect on the displayed data. Please verify whether the filter is fully implemented or if functionality is missing.

Screenshot

image

Calendar UX

Issue

  • Calendar navigation arrows are difficult to see.
  • Calendar UX could be improved by preventing invalid date selections.
  • Future dates should be disabled where appropriate.
  • Invalid date ranges should be prevented.

Screenshot

image

Log Material / Issue Pages

Issue

Both pages return a Page Not Found error.

Screenshot

image

Screenshot

image

Teams Page Navigation

Issue

The BM Projects option is not visible under Other Links on the Teams page. It appears to be clipped or hidden.

Screenshot

image

Teams Page Dark Mode

Issue

Dark mode styling is inconsistent on the Create New Team page.

Screenshot

image

UI Consistency

Issue

Different inventory pages use noticeably different table styles and layouts.

The UI should be more consistent across:

  • Materials
  • Consumables
  • Equipment
  • Reusables
  • Tools
  • Unit of Measurement

Mobile Responsiveness

Issue

Inventory pages should be optimized for smaller devices and mobile screens.

Screenshot

image

Summary

Verified

  • BM Dashboard navigation
  • Inventory navigation links
  • Expand/collapse functionality
  • Inventory category routing
  • Dark mode on inventory pages
  • BM Project dropdown navigation

Request Changes

The following issues should be addressed before approval:

  • Missing pages (Log Material / Issue)
  • Teams page navigation visibility issue
  • Date filter functionality concerns
  • Calendar UX improvements
  • Teams page dark mode inconsistency
  • Mobile responsiveness concerns
  • UI consistency improvements across inventory pages

AmaanSyed09
AmaanSyed09 previously approved these changes Jun 16, 2026

@AmaanSyed09 AmaanSyed09 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing Performed

  1. Verified the BM Dashboard is accessible through the Other Links dropdown.

  2. Verified All Inventory Types appears under the BM Projects dropdown menu.

  3. Verified selecting All Inventory Types correctly routes to /bmdashboard/inventorytypes.

  4. Verified the dropdown closes after selecting a menu option.

  5. Verified all inventory category navigation links function correctly:

    • Materials
    • Consumables
    • Equipment
    • Reusables
    • Tools
    • Unit of Measurement
  6. Verified each inventory category page loads successfully and displays the expected content.

  7. Verified the ← All Inventory Types navigation link is present on all category pages.

  8. Verified the ← All Inventory Types link correctly returns users to the Inventory Types page.

  9. Verified navigation works correctly in both Light Mode and Dark Mode.

  10. Verified Dark Mode styling remains consistent after navigating between inventory pages.

  11. Reviewed the modified files and confirmed the implemented changes align with the scope of the PR.

Additional Observation
The Issues item under the BM Projects dropdown currently routes to a Page Not Found page during local testing. Since this functionality does not appear to be part of the requirements described in this PR, I am noting it as an observation rather than a blocking issue. It may be worth verifying separately whether the route is expected to be functional.

Result: Approve

All requested functionality described in the PR was successfully tested and is working as expected.

Image Image Image Image Image Image Image

@sonarqubecloud

Copy link
Copy Markdown

@Dnagabahiru Dnagabahiru left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the PR locally after clearing cache and logging in as an admin user. Verified that the BM Dashboard header remains persistent, the new All Inventory Types option is available under BM Projects, and navigation to the Inventory Types page works as expected. Confirmed the updated dropdown structure, inventory icons, and navigation across all inventory categories (Materials, Consumables, Equipment, Reusables, Tools, and Unit of Measurement) function correctly.

Also verified that the ← All Inventory Types navigation link is present and returns users to the main Inventory Types page from each category. Tested all functionality in both Light Mode and Dark Mode, with consistent styling and expected behavior throughout. As an observation, the Issues option under BM Projects currently redirects to a Page Not Found page, which appears to be outside the scope of this PR.

Image Image Image Image Image Image

@Dnagabahiru Dnagabahiru requested review from Dnagabahiru and removed request for Dnagabahiru June 17, 2026 19:20

@Dnagabahiru Dnagabahiru left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the PR locally after clearing cache/site data and logging in as an admin user. Verified that the BM Dashboard header persistence, All Inventory Types entry, updated BM Projects dropdown structure, inventory category navigation, inventory icons, and Light/Dark Mode functionality are all working as expected.
During testing, I found two navigation issues within the BM Projects menu:
Issues redirects to a Page Not Found page.
Materials Log (logMaterial) also redirects to a Page Not Found page.
Since these options are exposed through the BM Projects navigation, users are able to access broken routes from the UI.
Result: Request Changes
Please resolve the broken navigation for Issues and Materials Log before approval.

Image Image Image Image Image Image Image Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible

Projects

None yet

Development

Successfully merging this pull request may close these issues.