Manoj - Add inventory navigation icons, cross-page links, and BM Dashboard dropdown under Other Links#5306
Manoj - Add inventory navigation icons, cross-page links, and BM Dashboard dropdown under Other Links#5306ManojPuttaswamy wants to merge 26 commits into
Conversation
✅ Deploy Preview for highestgoodnetwork-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
DeepighaJ
left a comment
There was a problem hiding this comment.
- Verified navigation to BM Dashboard through Other Links and confirmed the BM Dashboard header remains persistent after navigation as expected.
- Verified the new "All Inventory Types" option is available under the BM Projects dropdown and navigates correctly.
- Verified all inventory categories (Materials, Consumables, Equipments, Reusables, Tools, and Unit of Measurement) can be expanded and collapsed successfully.
- Verified navigation from All Inventory Types to individual category pages and confirmed category data is displayed correctly.
- Verified Back to All Inventory Types functionality works as expected from category pages.
- Verified the updated BM Projects dropdown structure and inventory type icons are displayed correctly.
Issue Found
Dark Mode UI Inconsistency: When navigating back from category pages (e.g., Materials, Consumables) to All Inventory Types using the "All Inventory Types" button or icons, some table elements retain light-theme styling instead of adopting dark-mode colors. This results in reduced readability and an inconsistent user experience in Dark Mode. (Refer last screenshot.)









HemanthNidamanuru
left a comment
There was a problem hiding this comment.
Hi Manoj,
I tested this locally following the steps provided and found 2 issues:
Unit of Measurement is missing from the BM Projects dropdown.
Dark mode - The BM Projects dropdown has a slight misalignment in dark mode.
PR.5306.mp4
amaresh2001
left a comment
There was a problem hiding this comment.
Tested locally on Manoj_BMDashboard.
Testing:
- "BM Dashboard" is correctly listed under the Other Links dropdown
- "All Inventory Types" appears in the BM Projects dropdown and routes correctly to /bmdashboard/inventorytypes
- Dropdown closes after selecting an option
- Categories (Materials, Consumables, Equipment, Reusables, Tools) are clickable navigation links with icons
- "← All Inventory Types" back link is present on each category page
Issues:
- Unit of Measurement is not a clickable link; all other categories on the Inventory Types page are clickable navigation links.
- Dark mode inconsistency on navigation back when in dark mode and navigating from a category page back to /bmdashboard/inventorytypes, the page body renders with a white/light background while the navbar remains dark. The page does not fully apply dark mode styling on return navigation.
Hi, the Issue 01 that you have mentioned, I believe Unit of Measurement is not supposed to be a clickable link. And, the second issue has been resolved. Please re review it. Thank you |
Hi, The first issue, I believe that the unit of measurement is not a category and hence there is no navigation to it. The second issue has been resolved. Please re review it. Thankyou |
Text me when the unit of measure link is fixed too, so I can request re-review |
Mahitha-pasupuleti
left a comment
There was a problem hiding this comment.
Hi Manoj,
I reviewed and tested this PR. The BM Dashboard header persists correctly across navigation, and the new "All Inventory Types" feature is functioning as expected. Navigation between inventory categories works properly, and the back to All Inventory Types functionality returns users to the main inventory page without issues.
I also verified the BM Projects dropdown structure, inventory type icons, and overall navigation flow. All functionality works correctly in both light mode and dark mode.
Everything is working according to the requirements. Approving this PR.
Abhi-R0211
left a comment
There was a problem hiding this comment.
Hi Manoj, I tested this PR locally across all navigation flows, dropdown behavior, and both light and dark modes. Here is my analysis:
What's Working Well
- BM Dashboard is correctly listed under the Other Links dropdown and persists after navigation
- "All Inventory Types" appears under BM Projects in the header and routes correctly to
/bmdashboard/inventorytypes
- All inventory categories (Materials, Consumables, Equipment, Reusables, Tools, Unit of Measurement) are visible with icons on the All Inventory Types page
- Dropdown closes after selecting an option
- Dark mode is retained when navigating back from a category page to All Inventory Types - the previously reported white background issue appears fixed
- BM Projects dropdown alignment in dark mode appears fixed
- Each category is a clickable navigation link and navigates to the correct page
- The "All Inventory Types" back button is present on each category page and functions correctly
Issues That Need To Be Addressed
1. Calendar Date Picker Misalignment in Dark Mode
The date/time picker on the All Inventory Types page (/bmdashboard/inventorytypes) has a slight misalignment in dark mode - the calendar popup is not properly anchored to the input field. Please fix the positioning so the picker aligns correctly with its input in dark mode.
2. Highlighted Text Color in Light Mode
On the All Inventory Types page in light mode, the highlighted/selected category text color does not provide sufficient contrast. Please adjust the highlight color to ensure readability in light mode.
handikaharianto
left a comment
There was a problem hiding this comment.
Hi @ManojPuttaswamy , I just reviewed the PR and here are my findings:
Good
bmdashboard header persistence under other links
“All Inventory Types” under the BM projects dropdown
I can see that all icons are mapped consistently with their inventory types.

dark/light modes work well
The layout is consistent across both dark/light modes.


Doubts
Materials -> Log Material page leads to not found page
This log material url leads to a not found page.

Add Consumable page doesn't show up
When I clicked on Consumables -> Add Consumables, the url added /add but the page to add consumables doesn't show up.

Inconsistency between the All Inventory Types page and dropdown
In the page, I can see that there is Unit of Measurement but it's not in the dropdown.

BM Projects -> Issues page is not found.
I noticed that clicking on the Issues url redirected me to a not found page.

UX improvement for navigating through the inventory types page.
Here, it's good that I can easily navigate through other inventory type pages, however, it might be better to add a tooltip when the user is hovering their mouse on the icon so that they know which inventory type it is.

BM Projects dropdown disappears
I noticed that the BM Projects dropdown only appears after only selecting a project in the Building and Inventory Management Dashboard. Is this the expected behavior?

|
Hi @ManojPuttaswamy I reviewed the pr and following are my reviews: BM Dashboard NavigationVerified
Screenshot
Responsive DesignIssueOn mobile/smaller screen widths, text does not wrap properly and the page does not appear fully responsive. All Inventory Types NavigationVerified
Screenshot
Inventory CategoriesVerifiedAll inventory categories can be expanded/collapsed and are clickable:
Screenshot
Dark ModeVerifiedDark mode styling appears to work correctly on the Inventory Types page. BM Projects DropdownVerifiedBM Projects dropdown displays the expected links and navigation works correctly. Screenshot
Date FilterIssueThe date filter appears to have no visible effect on the displayed data. Please verify whether the filter is fully implemented or if functionality is missing. Screenshot
Calendar UXIssue
Screenshot
Log Material / Issue PagesIssueBoth pages return a Page Not Found error. Screenshot
Screenshot
Teams Page NavigationIssueThe BM Projects option is not visible under Other Links on the Teams page. It appears to be clipped or hidden. Screenshot
Teams Page Dark ModeIssueDark mode styling is inconsistent on the Create New Team page. Screenshot
UI ConsistencyIssueDifferent inventory pages use noticeably different table styles and layouts. The UI should be more consistent across:
Mobile ResponsivenessIssueInventory pages should be optimized for smaller devices and mobile screens. Screenshot
SummaryVerified
Request ChangesThe following issues should be addressed before approval:
|
AmaanSyed09
left a comment
There was a problem hiding this comment.
Testing Performed
-
Verified the BM Dashboard is accessible through the Other Links dropdown.
-
Verified All Inventory Types appears under the BM Projects dropdown menu.
-
Verified selecting All Inventory Types correctly routes to
/bmdashboard/inventorytypes. -
Verified the dropdown closes after selecting a menu option.
-
Verified all inventory category navigation links function correctly:
- Materials
- Consumables
- Equipment
- Reusables
- Tools
- Unit of Measurement
-
Verified each inventory category page loads successfully and displays the expected content.
-
Verified the ← All Inventory Types navigation link is present on all category pages.
-
Verified the ← All Inventory Types link correctly returns users to the Inventory Types page.
-
Verified navigation works correctly in both Light Mode and Dark Mode.
-
Verified Dark Mode styling remains consistent after navigating between inventory pages.
-
Reviewed the modified files and confirmed the implemented changes align with the scope of the PR.
Additional Observation
The Issues item under the BM Projects dropdown currently routes to a Page Not Found page during local testing. Since this functionality does not appear to be part of the requirements described in this PR, I am noting it as an observation rather than a blocking issue. It may be worth verifying separately whether the route is expected to be functional.
Result: Approve
All requested functionality described in the PR was successfully tested and is working as expected.
08e9260 to
2c10510
Compare
|
Dnagabahiru
left a comment
There was a problem hiding this comment.
Tested the PR locally after clearing cache and logging in as an admin user. Verified that the BM Dashboard header remains persistent, the new All Inventory Types option is available under BM Projects, and navigation to the Inventory Types page works as expected. Confirmed the updated dropdown structure, inventory icons, and navigation across all inventory categories (Materials, Consumables, Equipment, Reusables, Tools, and Unit of Measurement) function correctly.
Also verified that the ← All Inventory Types navigation link is present and returns users to the main Inventory Types page from each category. Tested all functionality in both Light Mode and Dark Mode, with consistent styling and expected behavior throughout. As an observation, the Issues option under BM Projects currently redirects to a Page Not Found page, which appears to be outside the scope of this PR.
Dnagabahiru
left a comment
There was a problem hiding this comment.
Tested the PR locally after clearing cache/site data and logging in as an admin user. Verified that the BM Dashboard header persistence, All Inventory Types entry, updated BM Projects dropdown structure, inventory category navigation, inventory icons, and Light/Dark Mode functionality are all working as expected.
During testing, I found two navigation issues within the BM Projects menu:
Issues redirects to a Page Not Found page.
Materials Log (logMaterial) also redirects to a Page Not Found page.
Since these options are exposed through the BM Projects navigation, users are able to access broken routes from the UI.
Result: Request Changes
Please resolve the broken navigation for Issues and Materials Log before approval.

































Description
Related PRS (if any):
…
How to test:
npm installand...to run this PR locallyScreenshots or videos of changes:
REC-20260530200247.mp4
Notes: