Skip to content

Roshini Seelamsetty : Fix Blue Square Stats Chart Interactivity and Data Display (Total Org Summary)#5236

Open
roshini1212 wants to merge 1 commit into
developmentfrom
Roshini-Fix-Blue-Square-Stats-Chart-Interactivity-and-Data-Display
Open

Roshini Seelamsetty : Fix Blue Square Stats Chart Interactivity and Data Display (Total Org Summary)#5236
roshini1212 wants to merge 1 commit into
developmentfrom
Roshini-Fix-Blue-Square-Stats-Chart-Interactivity-and-Data-Display

Conversation

@roshini1212

@roshini1212 roshini1212 commented May 7, 2026

Copy link
Copy Markdown
Contributor

Description

Screenshot 2026-05-07 at 11 48 55

Main changes explained:

  • Updated DonutChart.jsx to filter zero-value categories from both chart slices and legend dynamically, with color index kept in sync after filtering
  • Updated DonutChart.jsx to move datalabels outside the arc so small segments (e.g. 1%) remain visible without being suppressed
  • Updated DonutChart.jsx to add text stroke halo on labels for legibility over any slice color in both light and dark mode
  • Updated DonutChart.jsx to fix legend text being invisible in light mode by driving color from the darkMode prop instead of var(--text-primary)
  • Updated DonutChart.module.css to increase canvas size to accommodate external labels and remove hardcoded color declarations that broke light mode

How to test:

  1. Check out branch Roshini-Fix-Blue-Square-Stats-Chart-Interactivity-and-Data-Display
  2. Run npm install and npm start to run locally
  3. Clear site data/cache
  4. Log in as admin user
  5. Go to Dashboard → Total Org Summary → Blue Square Stats chart
  6. Verify that categories with zero values do not appear in the chart slices or the legend
  7. Verify that all segment labels are visible outside the arc, including small slices like Missing Summary (1%) and Missing Hours (6%)
  8. Hover over each slice and verify the tooltip shows the correct label, count, and percentage

Screenshots or videos of changes:

Before:

PR 5236 Before

After:

Screen.Recording.2026-05-07.at.11.44.18.mov
Screenshot 2026-05-07 at 11 57 29 Screenshot 2026-05-07 at 11 57 52

…add hover effect, fix light mode legend text
@netlify

netlify Bot commented May 7, 2026

Copy link
Copy Markdown

Deploy Preview for highestgoodnetwork-dev ready!

Name Link
🔨 Latest commit 757ac62
🔍 Latest deploy log https://app.netlify.com/projects/highestgoodnetwork-dev/deploys/69fcb6ab212f8800087e64b3
😎 Deploy Preview https://deploy-preview-5236--highestgoodnetwork-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@sonarqubecloud

sonarqubecloud Bot commented May 7, 2026

Copy link
Copy Markdown

@one-community one-community added the High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible label May 22, 2026

@DeepighaJ DeepighaJ left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • The chart renders right data. No 0 values shown as expected. Minor UI suggestion, the values 440 and (6%) are very close together at the top, and overlapping the line.
  • The tooltip additionally includes a legend color marker beside the repeated label, making the duplication more noticeable
Image Image

@amaresh2001 amaresh2001 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally on Roshini-Fix-Blue-Square-Stats-Chart-Interactivity-and-Data-Display.

Testing:

  • Zero-value categories (e.g., Vacation Time, Other) are correctly hidden from both the chart slices and the legend.
  • Data labels are placed outside the arc, and small segments (1%) are clearly visible without being clipped or overlapping.
  • Hover tooltip works correctly on all slices, showing the correct label, count, and percentage.
  • Legend text is readable in light mode.
  • Dark mode is fully supported. Labels and legend remain readable.
Image Image Image

@beblicarl

Copy link
Copy Markdown
Contributor

This feature works as intended, and the code is great

image image

@beblicarl beblicarl self-requested a review June 5, 2026 08:27

@Mahitha-pasupuleti Mahitha-pasupuleti left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, chart is not displaying as intended. Tried using multiple date ranges

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants