Bump pgx to v5.9.2 and x/text to v0.39.0 - #95
Conversation
github.com/jackc/pgx/v5 was pinned at v5.8.0, which carries GO-2026-5004, a SQL injection through placeholder confusion with dollar-quoted string literals. govulncheck reaches it from db.Queries.ListVehiclesByUser at db/query.sql.go:734 through pgxpool.Pool.Query into sanitize.SanitizeSQL. golang.org/x/text at v0.34.0 carries GO-2026-5970, an infinite loop on invalid input, reached from db.Queries.VehicleExists at query.sql.go:973. There is no dependabot configuration in the repo, so neither had anything watching it. govulncheck reports no vulnerabilities after the bump.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe pull request updates ChangesDependency Version Updates
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This updates pgx and related Go dependencies to patched versions while preserving a passing build and test suite. No current merge-blocking risk is identified. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.) ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The problem
govulncheck ./...reports two vulnerabilities that your code actually reaches. Both have fixed releases available.GO-2026-5004, SQL injection in
github.com/jackc/pgxvia placeholder confusion with dollar-quoted string literals. This is a direct dependency, pinned atv5.8.0:GO-2026-5970, infinite loop on invalid input in
golang.org/x/text, indirect atv0.34.0:There is no
.github/dependabot.ymlin the repo, so nothing was watching either of them.The change
Only
go.modandgo.sumchange.golang.org/x/syncmoves from v0.19.0 to v0.21.0 as MVS resolves it.Verification
govulncheck ./...go build ./...clean,go test ./...passing.Worth considering separately
Adding a
.github/dependabot.ymlwith agomodentry would catch the next one automatically. Can send that as its own PR if you want it, though note that Dependabot only proposes updates for direct requirements, so an indirect module likex/textstill needsgovulncheckin CI to be caught reliably.Summary by CodeRabbit