Fix: Remove the "show tutorial" link in Settings

[gayatriii0803]

Fixes: #2267

Removed the "Show Tutorial" link in settings.

Please make sure these boxes are checked before submitting your pull request - thanks!

• Format your changes with ./gradlew spotlessApply.

• Run the unit tests with gradlew connectedObaGoogleDebugAndroidTest to make sure you didn't break anything

Summary by CodeRabbit

• Changes
  • Removed the Tutorial option from the Settings screen.
  • The Tutorial action is no longer available from Settings.
  • Removed obsolete tutorial text and analytics labels from the app’s supported languages.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 82e4499f-493e-4575-86fd-3a28c359a31b

📥 Commits

Reviewing files that changed from the base of the PR and between 62422bf and 967ea0c.

📒 Files selected for processing (9)

• onebusaway-android/src/main/java/org/onebusaway/android/ui/settings/SettingsDestinations.kt
• onebusaway-android/src/main/java/org/onebusaway/android/ui/settings/SettingsScreen.kt
• onebusaway-android/src/main/java/org/onebusaway/android/ui/settings/SettingsViewModel.kt
• onebusaway-android/src/main/res/values-es/strings.xml
• onebusaway-android/src/main/res/values-fi/strings.xml
• onebusaway-android/src/main/res/values-it/strings.xml
• onebusaway-android/src/main/res/values-pl/strings.xml
• onebusaway-android/src/main/res/values/donottranslate.xml
• onebusaway-android/src/main/res/values/strings.xml

💤 Files with no reviewable changes (9)

• onebusaway-android/src/main/res/values/strings.xml
• onebusaway-android/src/main/res/values/donottranslate.xml
• onebusaway-android/src/main/res/values-fi/strings.xml
• onebusaway-android/src/main/res/values-pl/strings.xml
• onebusaway-android/src/main/java/org/onebusaway/android/ui/settings/SettingsScreen.kt
• onebusaway-android/src/main/res/values-it/strings.xml
• onebusaway-android/src/main/java/org/onebusaway/android/ui/settings/SettingsDestinations.kt
• onebusaway-android/src/main/java/org/onebusaway/android/ui/settings/SettingsViewModel.kt
• onebusaway-android/src/main/res/values-es/strings.xml

Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review.

---

📝 Walkthrough

Walkthrough

The Settings screen no longer displays the Tutorial preference. Its click action, reset-navigation effect, destination callback, analytics label, and related localized strings were removed.

Changes

Settings Tutorial Link Removal

Layer / File(s)	Summary
Remove tutorial preference flow onebusaway-android/src/main/java/org/onebusaway/android/ui/settings/SettingsScreen.kt, onebusaway-android/src/main/java/org/onebusaway/android/ui/settings/SettingsViewModel.kt, onebusaway-android/src/main/java/org/onebusaway/android/ui/settings/SettingsDestinations.kt	The Tutorial preference, click action, reset-navigation effect, ViewModel method, and destination callback were removed.
Remove tutorial resources onebusaway-android/src/main/res/values/strings.xml, onebusaway-android/src/main/res/values-es/strings.xml, onebusaway-android/src/main/res/values-fi/strings.xml, onebusaway-android/src/main/res/values-it/strings.xml, onebusaway-android/src/main/res/values/donottranslate.xml	Tutorial preference strings and the tutorial analytics label were removed.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to 967ea

This PR removes the obsolete tutorial link from Settings and its related resources. No actionable merge-blocking risk remains beyond normal checks and review.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes removing the Show Tutorial link from Settings.
Linked Issues check	✅ Passed	The changes remove the Settings tutorial link, its callbacks, effects, actions, and obsolete resources as required by issue #2267.
Out of Scope Changes check	✅ Passed	All changes support removal of the Settings tutorial link and related unused code or resources.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[bmander]

In addition to removing the UI element please check if there's any plumbing that exists solely for this UI interaction and remove that too.

[bmander]

Looks good. Thank you!