Integrate/pr 42 language mapping - #44
Open
dgwatkins wants to merge 5 commits into
Open
Conversation
lang_slug_to_wpml_format() knew about exactly two languages, pt and zh. Everything else was passed to WPML as the raw Polylang slug, and WPML stores whatever it is given, so any site whose slug differed from the WPML code was migrated into a code WPML cannot resolve, silently. The dependable bridge is the locale: Polylang keeps it in the language term description, WPML keeps it in icl_languages.default_locale with per-site overrides in icl_locale_map. This resolves through WPML's own tables in reverse. Fixes Traditional Chinese (was migrated as Simplified), Norwegian, and any custom slug. Languages WPML still cannot match are recorded via get_unmapped_languages() instead of written blind.
This reverts commit 1889415.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.