test: cover local-command handlers and arg validation#75
Merged
Conversation
Add offline unit tests for LocalCommandRegistry's context-reading commands (:os/:arch/:host/:whoami/:node/:capabilities/:session/:info), registry behaviour (duplicate/alias registration, dedup+sort, alias dispatch, blank/non-local lines), and the no-network argument-validation branches of :tunnel, :drive and :detach. Raises local_command.dart coverage 26.7% -> 42.0% and overall line coverage 76.9% -> 78.6%. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improves test coverage by targeting the biggest real gap —
local_command.dart(was 26.7%, 569 uncovered lines), the interactive:command layer. (The 0%winpty_*files are Windows-only and already covered by the Windows CI runner.)Adds 23 offline unit tests (no live Hub connection required):
:os,:arch,:host,:whoami(with/without principal, sorted roles),:node(with/without labels),:capabilities(with/without advertised caps),:session,:info(UID + labels + fixed-clock session duration via an injected clock).ArgumentErrors, command dedup + sort, alias dispatch (:quit→ exit), blank:lines, non-local lines returningfalse.:tunnel(usage, port range, malformed--public-port,closewith no id),:drive(unknown subcommand, missing mount-id for status/sync/diff/conflicts/remount,--push+--pullconflict,unwatchwith no watchers),:detachwith no session.Results
local_command.dartdart analyzeon the test file is clean. A smallchorecommit gitignores the generatedcoverage/directory.🤖 Generated with Claude Code