feat(security): implement in-memory fallback for OS keychain (fixes #8) - #83
Open
Diwakar-odds wants to merge 1 commit into
Open
feat(security): implement in-memory fallback for OS keychain (fixes #8)#83Diwakar-odds wants to merge 1 commit into
Diwakar-odds wants to merge 1 commit into
Conversation
Contributor
Author
|
Hi maintainers! Thanks for reviewing this PR. Technical AnalysisThis PR closes the final gap in Issue #8 by implementing the graceful fallback mechanism for the OS keychain. When running in environments where keyring::Entry initialization or password setting fails (e.g., CI environments, misconfigured Linux secret services, or locked keychains), the keychain service now cleanly falls back to an in-memory OnceLock<RwLock<HashMap<String, String>>>. This ensures that API keys (like OpenRouter) can still be set and retrieved temporarily without crashing the application. ECSoC26 Label JustificationBased on the ECSoC '26 Guidelines, this PR involves:
Could you please review this PR and consider adding the ECSoC26, ECSoC26-L3, and good-backend labels if you agree with the assessment? Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Summary
Implemented OS Keychain fallback mechanism (Fixes #8).
Related Issue
Fixes #8
Type of Change
Changes Made
Testing
Checklist
Additional Notes
Ensures robust failure handling in headless/unsupported linux environments for CI and container builds.