fix: announce camera focus changes - #2129
Open
mittalsonal wants to merge 1 commit into
Open
Conversation
|
@mittalsonal is attempting to deploy a commit to the Sp's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
Tick the box to add this pull request to the merge queue (same as
|
Contributor
Author
|
Maintainer note: I checked the red statuses. The code-owned \ ypecheck\ job is passing, and local verification also passed for the focused test, targeted lint, typecheck, and build. The remaining red statuses appear to be repository integration/permission blockers rather than implementation failures: Vercel requires team authorization for fork deploys, and the auto-label workflow is failing with fork PR token permissions while trying to add labels. Happy to adjust anything code-related if you spot an issue during review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Closes #2084
Change Summary
cameraAnnouncementstate value in the app provider.Camera focused on AST-0042.andCamera returned to Earth.Suggested Area
Accessibility
Core Files Changed
src/components/Header.tsxsrc/lib/store.tsxsrc/__tests__/Header.test.tsxVerification
npm test -- --run src/__tests__/Header.test.tsx- passed, 1 test.npm run typecheck- passed.npx eslint src/components/Header.tsx src/lib/store.tsx src/__tests__/Header.test.tsx --format json- passed, clean result for touched files.npm run build- passed.git diff --cached --check- passed.AI Assistance Declaration
Did you use an AI tool to write or assist with this code OR Pull Request?
Yes
No
Which AI Model did you use?: GPT-5 Codex
Which Platform/Tool?: Codex
What exactly did the AI do?: Assisted with repository inspection, implementation, tests, and verification commands.
What exactly did YOU do?: Reviewed the assigned task, kept the change scoped, verified account/repo safety, and validated locally.
What is the advantage of using this AI approach here?: Faster accessibility-focused implementation with regression coverage and repeatable verification.
Reviewer Notes
docs/ARCHITECTURE.mdchanges were not included in this PR.Local Verification Pledge