Add missing jsdom dev dependency to fix vitest environment #722 - #2092
Open
vansh2604-star wants to merge 4 commits into
Open
Conversation
|
Someone is attempting to deploy a commit to the Sp's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
Tick the box to add this pull request to the merge queue (same as
|
…fix-Vitest-environment--Omnikon-Org#722
Contributor
Author
|
@Mergifyio queue |
☑️ Command disallowed due to command restrictions in the Mergify configuration.Details
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Related Issue
Closes #722
📝 Description of Changes
Added the missing
jsdomdevelopment dependency to the project's configuration to prevent Vitest from crashing due to an unhandled module resolution error. This environment is required by thetextures.test.tssuite.🏷️ Proposed Labels
📂 Core Files Changed
📸 Verification & Screenshots
UI/UX (User Interface / User Experience - how it looks and feels):
N/A
CI/CD (Continuous Integration / Continuous Deployment - the automated build/test pipeline):
Ran the Vitest suite locally using
npm test. All 26 assertions from bothkepler.test.tsandtextures.test.tspassed successfully without any environment-related module resolution errors:🤖 AI Assistance Declaration
Did you use an AI tool to write or assist with this code OR Pull Request?
jsdompackage from thepackage.jsonconfigurations, installed it, and verified that both test suites run and pass successfully.jsdom, ran the git commands to commit and push the branch, and initiated the PR.The change is minimal, introducing only the
jsdomdevDependency to fix the test suite crash.✅ The "I Swear I Didn't Break Anything" Pledge