Started work on .slnx format support - #2711
Open
Wallby wants to merge 1 commit into
Open
Conversation
Author
|
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per the CLA:
What works:
What doesn't work:
The actual functionality has not been tested yet. There are a few question marks that I have committed as-is:
Microsoft.VisualStudio.SolutionPersistence.Serializerimplementation to figure out how to use it instead of the old text-parsing. The information for paths and names is available, so adjusting it I expect to not be a lot of work.Path.Combine), not sure if that is an issue for this projectProjectIdInfo.SolutionConfigurationsdictionary used to contain a different value. Currently it contains the same value as key. I was not entirely sure what to do about that. Are both parts even used anymore? Or can this be changed to an array of configuration strings? So feedback about that would be appreciated.Given the force-pushing at #2703, I decided to start a separate pull request. Such that any changes to this pull request can be tracked.