Fix LOD promotion flicker in fullscreen mode - #930
Draft
OliverZhaohaibin wants to merge 4 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request implements a robust, multi-phase LOD (Level of Detail) promotion pipeline for still image zoom in the player view. The changes ensure that LOD upgrades are staged as non-active residents before activation, with detailed event tracking and cancellation logic to handle rapid user interactions and failed promotions. The update also introduces a 200ms idle debounce for zoom, improved event emission for analytics, and better separation of staging, activation, and presentation phases.
Player View LOD Promotion Pipeline Improvements:
_LOD_IDLE_DELAY_MS), and emit detailedstill_zoom_changedandlod_upgrade_requestedevents for analytics and debugging. [1] [2] [3] [4]lod_upgrade_staging,lod_upgrade_resident,lod_upgrade_activated,lod_upgrade_presented). [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12]Documentation and Benchmarking Updates:
Texture Management Enhancements:
stage_still_textureto allow foreground LOD uploads without replacing the active texture, supporting the new promotion pipeline.These changes make the still image zoom experience more robust, responsive, and observable, while ensuring correctness even during rapid user actions or resource contention.