#401 Add Web file downloads and bounded image previews - #404
Open
OldKrab wants to merge 4 commits into
Open
Conversation
OldKrab
enabled auto-merge (squash)
September 8, 2026 11:03
OldKrab
disabled auto-merge
September 8, 2026 11:15
OldKrab
enabled auto-merge (squash)
September 8, 2026 11:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Web file links could open an unsupported preview with no way to retrieve the file. Large photos also failed preview, and a parent rerender could release a viewer handle while leaving its preview visible, causing Download to report a false “File not found”.
Changes
Closes #401.
Verification
Passed during implementation: 198 protocol boundary tests, 12 viewer tests, additional Markdown/file-reference tests, and three desktop/phone browser scenarios covering current bytes, Unicode symlinks, missing-file retry, large-photo preview, zoom, and original downloads. Target deployment and readiness were verified.
npm run ci— local checks and tests passed; the aggregate build step could not find the binary because the Rust target directory was redirected. GitHub production build passed on the initial PR revision.CI follow-up: replaced the config-catalog ordering test's polling and timed receive with a two-phase barrier and worker join. The synchronized test passed 20 consecutive runs; the full Rust workspace suite, Clippy, and formatting passed.
AGENTS.mdnow requires synchronization primitives for ordering tests instead of sleeps or short deadlines.