Skip to content

zenoのdeno runから--を取り除いた - #20

Merged
Ojoxux merged 1 commit into
mainfrom
fix-zeno-deno-run
Sep 30, 2026
Merged

Ojoxux merged 1 commit into
mainfrom
fix-zeno-deno-run

Conversation

@Ojoxux

@Ojoxux Ojoxux commented Sep 30, 2026

Copy link
Copy Markdown
Owner

No description provided.

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes

Reviewed the new postPatch step in modules/zeno.nix against upstream zeno.zsh at the pinned rev 2e8fbec, along with the matching AGENTS.md note.

  • Strip -- before the zeno entrypoint — a sed -i -E over bin/ and shells/ drops the -- in front of "…/src/cli.ts" and "…/src/server.ts". The grep guard fails the build if upstream changes, following the existing --node-modules-dir patch.
  • Document the deno 2.9 regression — AGENTS.md explains that deno run <flags> -- <script> falls back to deno task, so the socket server never starts and zeno-history-precmd stalls each prompt for about 5s.

I checked the regex against the upstream source. It matches every deno run … -- <script> site in the zsh and fish wrappers, including bin/zeno, bin/zeno-server, and shells/{zsh,fish}/functions/zeno{,-server}. It also matches the two deno cache … -- "…/src/cli.ts" calls in shells/zsh/functions/zeno-init and shells/fish/conf.d/zeno.fish. Removing -- there does no harm, since deno cache takes the file as a plain positional argument. The only other deno run in upstream is the fallback in src/command/commands/index.ts, and it never used --.

Pullfrog  | View workflow run | Using Claude Opus | 𝕏

@Ojoxux
Ojoxux merged commit f73bec9 into main Sep 30, 2026
3 checks passed
@Ojoxux
Ojoxux deleted the fix-zeno-deno-run branch September 30, 2026 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant