[WIP] Another round of fixing flaky tests - #17361
Draft
syjn99 wants to merge 1 commit into
Draft
Conversation
…lColumnExchange` Make this test deterministic even in a single CPU. Pubsub attaches already-connected peers at startup, while it is triggered by identify event which can be delivered unreliably in our "blank host" setting (`UseBlankHost: true`). Currently go test always fails with: ``` go test ./beacon-chain/p2p/partialdatacolumnbroadcaster/integrationtest/ \ -run TestTwoNodePartialColumnExchange -count=200 -cpu 1 ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this PR do? Why is it needed?
Which issue(s) does this PR fix?
Fixes #
Other notes for review
Acknowledgements