[EIP-8148]: Implement https://github.com/ethereum/EIPs/pull/12146. - #17351
Draft
nalepae wants to merge 1 commit into
Draft
[EIP-8148]: Implement https://github.com/ethereum/EIPs/pull/12146.#17351nalepae wants to merge 1 commit into
nalepae wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature
What does this PR do? Why is it needed?
This pull requests only focused on implementing:
related to EIP-8148.
It allows a validator to set a custom sweep threshold directly at deposit time.
How to test it:
Use the following kurtosis configuration file:
The Dora docker image must be built from https://github.com/nalepae/dora.
Once the Gloas fork Epoch is reached, you can check the
validator_sweep_thresholdsvalues in the beacon state.Everything should be set at 2048 ETH.
Save the following assertoor test file in your system:
The important part is:
containing the
100 ETHthreshold data (0x0064) just before the withdrawal address.and register it to Assertoor with:
Important
Don't forget the
@before the file path.Once done, trigger the corresponding new validator deposit with:
Once the validator is effectively deposited, you can check the
validator_sweep_thresholdsvalues in the beacon state.The new (latest) validator should have the
100 ETHthreshold.Acknowledgements