Dedup (un)marshal methods in validator/client/iface/validator_client.go - #17340
Open
syjn99 wants to merge 1 commit into
Open
Dedup (un)marshal methods in validator/client/iface/validator_client.go#17340syjn99 wants to merge 1 commit into
validator/client/iface/validator_client.go#17340syjn99 wants to merge 1 commit into
Conversation
james-prysm
reviewed
Aug 13, 2026
| ValidatorIndex string `json:"validator_index"` | ||
| } | ||
|
|
||
| func (b *BeaconCommitteeSelection) MarshalJSON() ([]byte, error) { |
Contributor
There was a problem hiding this comment.
do we have any test to prove this?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this PR do? Why is it needed?
Cleaning up - we don't need custom marshal methods.
BeaconCommitteeSelectionandSyncCommitteeSelectionare used only in wire that uses JSON.Which issue(s) does this PR fix?
N/A
Other notes for review
Acknowledgements