Conversation
… the Gloas fork rather than Heze.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Other
What does this PR do? Why is it needed?
POC: Implement EIP-8148 (custom sweep threshold for validators).
Important
No EL currently supports the Heze fork, so we chose to build this POC as part of the Gloas fork rather than the Heze fork.
Important
No EL currently supports this EIP, so we chose to implement a custom debug endpoint directly in Prysm to "simulate" a sweep threshold change coming from the EL. This endpoint is
/prysm/v1/debug/beacon/sweep_threshold_requests.This comes with some limitations, like a very limited Dora support.
Kurtosis configuration file
The Dora docker image must be built from https://github.com/nalepae/dora.
Recipe:
validator_sweep_thresholdsvalues in the beacon state.Everything should be set at 2048 ETH.
2048 ETH -> 33ETHwithdrawal threshold change request for validators 0 and 1 to the beacon node with:You should see in the beacon logs:
then:
The values of
validator_sweep_thresholdsin the beacon state for validators 0 and 1 are now 33 ETH. The rest is still 2048 ETH.Now, you can wait for a long time for the effective balance of validators 0 and 1 to reach 33.25 ETH, or you can make a deposit.
and register it to Assertoor with:
Important
Don't forget the
@before the file path.(
balanceis slightly higher than 33 ETH andeffective_balanceis exactly 34 ETH)After the start of the next epoch, the same request should return:
(
balanceis slightly higher than 33 ETH andeffective_balanceis exactly 33 ETH)Other notes for review
Acknowledgements