Add WithRPCClientDialer option to inject the execution node RPC client - #17334
Open
satushh wants to merge 2 commits into
Open
Add WithRPCClientDialer option to inject the execution node RPC client#17334satushh wants to merge 2 commits into
satushh wants to merge 2 commits into
Conversation
satushh
marked this pull request as ready for review
August 12, 2026 17:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature
What does this PR do? Why is it needed?
execution.WithRPCClientDialer, that lets the host hand the service a function returning a ready*rpc.Client(e.g. fromgethRPC.DialInProc) instead of an endpoint string.--execution-endpoint, so rejecting the combination would make the option unusable through the normal node startup path.node.WithExecutionChainOptions.node.New(ctx, cancel, node.WithExecutionChainOptions([]execution.Option{execution.WithRPCClientDialer(func(ctx context.Context) (*gethRPC.Client, error) { return gethRPC.DialInProc(gethInProcHandler), nil })}), ...)(after which every Engine API call travels in-memory instead of over a socket).
Which issue(s) does this PR fix?
Fixes #
Other notes for review
Acknowledgements