Add per-beacon-node response attribution to the REST multi-handler - #17323
Open
syjn99 wants to merge 1 commit into
Open
Add per-beacon-node response attribution to the REST multi-handler#17323syjn99 wants to merge 1 commit into
syjn99 wants to merge 1 commit into
Conversation
With multiple beacon nodes configured, nothing told the operator which
node was actually serving the useful responses:
validator_http_action_count has no host label, and the multi-handler
discarded which handler won a read.
Add validator_beacon_node_response_total{host,outcome} at the two choke
points that already pick a winner, raceRound and inOrderRound, recording
whether a node's response was matched, used as a best-effort fallback,
or errored within a read round. Host labels go through
api.RedactEndpoint: endpoints can carry basic-auth credentials, which
must not reach /metrics.
No endpoint label: endpoints embed the slot, so the cardinality would be
unbounded.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this PR do? Why is it needed?
Add
validator_beacon_node_response_total{host,outcome}metrics (outcome =matched|fallback|error) that surfaces which BN that VC relies most. With #17075, REST VC is now able to subscribe N BNs, performing duties based on the best result on hand. This PR provides a chance for node operators to actually investigate under the hood. It's possible that one BN always wins inraceRound, while other always loses so contributes nothing on VC.No endpoint label for this metric: endpoints embed the slot, so the cardinality would be unbounded.
Which issue(s) does this PR fix?
N/A
Other notes for review
Might be great if we add a sample Grafana dashboard in the documentation that @nalepae already wrote:
Acknowledgements