Return the decode error from the remote web3signer client's response unmarshalling - #17321
Open
syjn99 wants to merge 1 commit into
Open
Return the decode error from the remote web3signer client's response unmarshalling#17321syjn99 wants to merge 1 commit into
syjn99 wants to merge 1 commit into
Conversation
syjn99
commented
Aug 7, 2026
| config := &SetupConfig{ | ||
| BaseEndpoint: "http://example.com", | ||
| GenesisValidatorsRoot: root, | ||
| PublicKeysURL: "http://example2.com/api/v1/eth2/publicKeys", |
Member
Author
There was a problem hiding this comment.
No PublicKeysURL: Sign only needs the mocked client, and a real URL would hit the network.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this PR do? Why is it needed?
In
unmarshalResponse,erris shadowed soerrors.Wrap(err, ...)at line 199 returnsnil, nil. It's interesting that this bug also surfaces whatTestKeymanager_Signtest configuration, asPublicKeysURL(example2.com) actually responds with malformed JSON. See the additional comment.Which issue(s) does this PR fix?
N/A
Other notes for review
Regression test is included.
Acknowledgements