chore: fix the format of the deprecated comment - #15692
Conversation
|
If we are going to introduce this kind of change, we should include some kind of github workflow or CI check to enforce it going forward. Can you add one? |
@prestonvanloon Sorry for handling this so late. I have added a CI to detect these issues. Please review again. |
|
Hi, @prestonvanloon If there's anything need I to do, please feel free to let me know. |
|
@reddaisyy looks like your CI check is failing. If we are going to address this, then we should resolve it everywhere. |
Sorry for deal so late. @prestonvanloon Thanks for pointing this out. The previous CI check scanned the entire repository, but the PR only fixed one occurrence, so it still failed on beacon-chain/rpc/prysm/v1alpha1/node/server.go. I've updated the PR on top of the latest develop branch and fixed all remaining The relevant package tests and local workflow checks pass. Could you please take another look? |
What type of PR is this?
What does this PR do? Why is it needed?
gocriticthrow a warning:deprecatedComment: use Deprecated: (note the casing) instead of DEPRECATED:Which issues(s) does this PR fix?
Fixes #
Other notes for review
Acknowledgements