Skip to content

chore: fix the format of the deprecated comment - #15692

Open
reddaisyy wants to merge 1 commit into
OffchainLabs:developfrom
reddaisyy:develop
Open

chore: fix the format of the deprecated comment#15692
reddaisyy wants to merge 1 commit into
OffchainLabs:developfrom
reddaisyy:develop

Conversation

@reddaisyy

@reddaisyy reddaisyy commented Sep 15, 2025

Copy link
Copy Markdown

What type of PR is this?

Documentation

What does this PR do? Why is it needed?

gocritic throw a warning: deprecatedComment: use Deprecated: (note the casing) instead of DEPRECATED:

Which issues(s) does this PR fix?

Fixes #

Other notes for review

Acknowledgements

@CLAassistant

CLAassistant commented Sep 15, 2025

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@prestonvanloon

Copy link
Copy Markdown
Member

If we are going to introduce this kind of change, we should include some kind of github workflow or CI check to enforce it going forward. Can you add one?

@reddaisyy

Copy link
Copy Markdown
Author

If we are going to introduce this kind of change, we should include some kind of github workflow or CI check to enforce it going forward. Can you add one?

@prestonvanloon Sorry for handling this so late.

I have added a CI to detect these issues.

Please review again.

@reddaisyy

Copy link
Copy Markdown
Author

Hi, @prestonvanloon If there's anything need I to do, please feel free to let me know.

@prestonvanloon

Copy link
Copy Markdown
Member

@reddaisyy looks like your CI check is failing. If we are going to address this, then we should resolve it everywhere.

@reddaisyy

Copy link
Copy Markdown
Author

@reddaisyy looks like your CI check is failing. If we are going to address this, then we should resolve it everywhere.

Sorry for deal so late.

@prestonvanloon Thanks for pointing this out. The previous CI check scanned the entire repository, but the PR only fixed one occurrence, so it still failed on beacon-chain/rpc/prysm/v1alpha1/node/server.go.

I've updated the PR on top of the latest develop branch and fixed all remaining DEPRECATED: comments. I also moved the enforcement into the existing Go lint workflow using a targeted git grep check, and added a changelog fragment.

The relevant package tests and local workflow checks pass. Could you please take another look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants