-
Notifications
You must be signed in to change notification settings - Fork 734
Construct init msg without consensus #4395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
47 commits
Select commit
Hold shift + click to select a range
e85ece4
Split GetConsensusParsedInitMsg into two variants
pmikolajczyk41 850f48d
into 3 variants
pmikolajczyk41 911e97c
Adapt system tests that were just reading msg from consensus
pmikolajczyk41 3a84783
Adapt tests
pmikolajczyk41 c31155d
Small fix
pmikolajczyk41 ccbb095
Changelog
pmikolajczyk41 a09bba9
fmt
pmikolajczyk41 df0a54e
Fix getinithelper
pmikolajczyk41 61f1e76
Fix nilpointers
pmikolajczyk41 96f46fe
typo
pmikolajczyk41 f449e61
Merge remote-tracking branch 'origin/master' into pmikolajczyk/nit-42…
pmikolajczyk41 5576ecf
Merge remote-tracking branch 'origin/master' into pmikolajczyk/nit-42…
pmikolajczyk41 47d2414
Add GenesisOverride substruct
pmikolajczyk41 b0d9fbd
s/TestGetParsedInitMsgFromConsensus/TestGetParsedInitMsgFromParentChain
pmikolajczyk41 629e9f8
Fix the fetching and comparing flow
pmikolajczyk41 ce1d76c
Merge remote-tracking branch 'origin/master' into pmikolajczyk/nit-42…
pmikolajczyk41 994e86c
fmt
pmikolajczyk41 29b465d
Merge remote-tracking branch 'origin/master' into pmikolajczyk/nit-42…
pmikolajczyk41 7ac6868
Merge branch 'master' into pmikolajczyk/nit-4242-construct-init-msg
pmikolajczyk41 2956daa
Merge remote-tracking branch 'origin/master' into pmikolajczyk/nit-42…
pmikolajczyk41 b14aaa2
Clarify comment in IsSet
pmikolajczyk41 5cdeeef
s/GenesisOverride/GenesisOverrideConfig
pmikolajczyk41 f5fcc37
Remove validateParsedInitMessagesMatch
pmikolajczyk41 53b24e4
Run check also for nil
pmikolajczyk41 21d6cfa
Log message instructions
pmikolajczyk41 e8abb34
Require ArbOSInit.InitialL1BaseFee in genesis instead of falling back…
pmikolajczyk41 07c3a2a
log lines indicating from which source Execution retrieved parsed ini…
pmikolajczyk41 daeed5c
write the initial l1 base fee in log
pmikolajczyk41 941c090
minor fixed
pmikolajczyk41 8334ec3
TestGetExecutionParsedInitMsg
pmikolajczyk41 cc986a7
Add arbosinit to testgenesis
pmikolajczyk41 637484e
Merge remote-tracking branch 'origin/master' into pmikolajczyk/nit-42…
pmikolajczyk41 9fb636d
Revert "Remove validateParsedInitMessagesMatch"
pmikolajczyk41 49d1f69
Add info that it was read from parent chain
pmikolajczyk41 252e24f
Tell operator what is the default
pmikolajczyk41 a9a51d3
Do not hardcode
pmikolajczyk41 b6011c4
Full override validation
pmikolajczyk41 c978a2d
Clarify log
pmikolajczyk41 984cd9a
run validateChainConfigCompatibility with any parsed message
pmikolajczyk41 73cb2de
Fix test
pmikolajczyk41 69fb0af
Require neither or both parameters in override
pmikolajczyk41 2983735
Remove redundant test
pmikolajczyk41 48f1871
Merge remote-tracking branch 'origin/master' into pmikolajczyk/nit-42…
pmikolajczyk41 ecb1930
Parse fee only when chainConfigSet is true
pmikolajczyk41 e638907
Chain config shouldn't be nil
pmikolajczyk41 d5c674a
Return error if fee not set
pmikolajczyk41 b563224
Remove unneeded test
pmikolajczyk41 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| ### Added | ||
| - Nitro can restore parsed init message from genesis, without access to the consensus side |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.