Skip to content

Precompiles for multi dimensional multi constraint pricer - #3995

Merged
eljobe merged 10 commits into
masterfrom
precompiles-for-multi-dimensional-multi-constraint-pricer
Nov 24, 2025
Merged

eljobe merged 10 commits into
masterfrom
precompiles-for-multi-dimensional-multi-constraint-pricer

Conversation

@MishkaRogachev
MishkaRogachev force-pushed the precompiles-for-multi-dimensional-multi-constraint-pricer branch 3 times, most recently from 9ebeadf to ac126a8 Compare November 13, 2025 11:55
@github-actions

github-actions Bot commented Nov 13, 2025 •

Copy link
Copy Markdown
Contributor

❌ 2 Tests Failed:

Tests completed Failed Passed Skipped
2173 2 2171 0
View the top 2 failed tests by shortest run time
TestValidationInputsAtWithWasmTarget
Stack Traces | 3.070s run time
... [CONTENT TRUNCATED: Keeping last 20 lines]
=== CONT  TestValidationInputsAtWithWasmTarget
    validation_inputs_at_test.go:70: goroutine 1489505 [running]:
        runtime/debug.Stack()
        	/opt/hostedtoolcache/go/1.25.4/x64/src/runtime/debug/stack.go:26 +0x5e
        github.com/offchainlabs/nitro/util/testhelpers.RequireImpl({0x40e2c90, 0xc069440540}, {0x40a00a0, 0xc075a40c20}, {0x0, 0x0, 0x0})
        	/home/runner/work/nitro/nitro/util/testhelpers/testhelpers.go:29 +0x55
        github.com/offchainlabs/nitro/system_tests.Require(0xc069440540, {0x40a00a0, 0xc075a40c20}, {0x0, 0x0, 0x0})
        	/home/runner/work/nitro/nitro/system_tests/common_test.go:1759 +0x5d
        github.com/offchainlabs/nitro/system_tests.TestValidationInputsAtWithWasmTarget(0xc069440540)
        	/home/runner/work/nitro/nitro/system_tests/validation_inputs_at_test.go:70 +0x970
        testing.tRunner(0xc069440540, 0x3d25700)
        	/opt/hostedtoolcache/go/1.25.4/x64/src/testing/testing.go:1934 +0xea
        created by testing.(*T).Run in goroutine 1
        	/opt/hostedtoolcache/go/1.25.4/x64/src/testing/testing.go:1997 +0x465
        
    validation_inputs_at_test.go:70: �[31;1m [] failed calculating position for validation: batch not found on L1 yet �[0;0m
ERROR[11-24|14:00:40.853] Dangling trie nodes after full cleanup
INFO [11-24|14:00:40.879] HTTP server stopped                      endpoint=127.0.0.1:35317
TRACE[11-24|14:00:40.879] P2P networking is spinning down
--- FAIL: TestValidationInputsAtWithWasmTarget (3.07s)
TestEthSyncing
Stack Traces | 26.900s run time
... [CONTENT TRUNCATED: Keeping last 20 lines]
INFO [11-24|13:55:57.477] Resuming snapshot generation             root=56e81f..63b421 accounts=0  slots=0     storage=0.00B   dangling=0 elapsed="408.462µs"
DEBUG[11-24|13:55:57.477] Journalled generator progress            progress=empty
TRACE[11-24|13:55:57.477] Proved state range                       kind=account prefix=0x61 last=0x
DEBUG[11-24|13:55:57.477] Journalled generator progress            progress=done
INFO [11-24|13:55:57.478] Generated snapshot                       accounts=0  slots=0     storage=0.00B   dangling=0 elapsed="480.887µs"
DEBUG[11-24|13:55:57.477] Executing EVM call finished              runtime="302.294µs"
DEBUG[11-24|13:55:57.478] Served eth_call                          reqid=1914 duration="414.656µs"
TRACE[11-24|13:55:57.478] Handled RPC response                     reqid=1914 duration="2.544µs"
DEBUG[11-24|13:55:57.478] Created new diff layer                   id=1                  block=0   nodesize=4.25KiB  statesize=2.01KiB
DEBUG[11-24|13:55:57.478] Stored state history                     id=1                  block=0   data=0.00B   index=891.00B elapsed="36.478µs"
INFO [11-24|13:55:57.478] 
INFO [11-24|13:55:57.478] ---------------------------------------------------------------------------------------------------------------------------------------------------------
DEBUG[11-24|13:55:57.478] Created new diff layer                   id=1                  block=0   nodesize=4.25KiB  statesize=2.01KiB
INFO [11-24|13:55:57.478] Chain ID:  1337 (unknown)
INFO [11-24|13:55:57.478] Consensus: unknown
INFO [11-24|13:55:57.478] 
--- FAIL: TestEthSyncing (26.90s)
INFO [11-24|13:55:57.478] Pre-Merge hard forks (block based):
DEBUG[11-24|13:55:57.478] Executing EVM call finished              runtime="380.79µs"
DEBUG[11-24|13:55:57.478] Served eth_call                          reqid=1915 duration="425.573µs"

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov

@MishkaRogachev
MishkaRogachev force-pushed the precompiles-for-multi-dimensional-multi-constraint-pricer branch 2 times, most recently from 07e69a6 to 32736b1 Compare November 13, 2025 13:03
@MishkaRogachev
MishkaRogachev marked this pull request as ready for review November 13, 2025 14:19
@MishkaRogachev
MishkaRogachev force-pushed the precompiles-for-multi-dimensional-multi-constraint-pricer branch from 32736b1 to f141d31 Compare November 14, 2025 10:58
@MishkaRogachev
MishkaRogachev force-pushed the precompiles-for-multi-dimensional-multi-constraint-pricer branch from f141d31 to 0b6beab Compare November 14, 2025 11:36
Comment thread arbos/l2pricing/model.go Outdated
Comment thread precompiles/ArbGasInfo.go Outdated
Comment thread precompiles/ArbOwner.go
if err != nil {
return fmt.Errorf("failed to compute exponent for resource kind %v: %w", kind, err)
}
if exp > MaxExponentBips {

@MishkaRogachev MishkaRogachev Nov 14, 2025 •

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gligneul I'm not 100% sure it's a good place for this check. Probably in the following PR with implemented model it's worth to extract math into a pure function and use it to sample new base fee for all constraints at once

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, but this code is good also.

@gligneul gligneul assigned eljobe and unassigned gligneul Nov 14, 2025
@eljobe
eljobe added this pull request to the merge queue Nov 24, 2025
Merged via the queue into master with commit 7ce0519 Nov 24, 2025
25 checks passed
@eljobe
eljobe deleted the precompiles-for-multi-dimensional-multi-constraint-pricer branch November 24, 2025 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants