Repository navigation
Precompiles for multi dimensional multi constraint pricer - #3995
Merged
eljobe merged 10 commits intoNov 24, 2025
Merged
Conversation
MishkaRogachev
force-pushed
the
precompiles-for-multi-dimensional-multi-constraint-pricer
branch
3 times, most recently
from
November 13, 2025 11:55
9ebeadf to
ac126a8
Compare
Contributor
❌ 2 Tests Failed:
View the top 2 failed tests by shortest run time
📣 Thoughts on this report? Let Codecov know! | Powered by Codecov |
This was referenced Nov 13, 2025
MishkaRogachev
force-pushed
the
precompiles-for-multi-dimensional-multi-constraint-pricer
branch
2 times, most recently
from
November 13, 2025 13:03
07e69a6 to
32736b1
Compare
This was referenced Nov 13, 2025
MishkaRogachev
marked this pull request as ready for review
November 13, 2025 14:19
MishkaRogachev
force-pushed
the
precompiles-for-multi-dimensional-multi-constraint-pricer
branch
from
November 14, 2025 10:58
32736b1 to
f141d31
Compare
MishkaRogachev
force-pushed
the
precompiles-for-multi-dimensional-multi-constraint-pricer
branch
from
November 14, 2025 11:36
f141d31 to
0b6beab
Compare
gligneul
requested changes
Nov 14, 2025
MishkaRogachev
commented
Nov 14, 2025
| if err != nil { | ||
| return fmt.Errorf("failed to compute exponent for resource kind %v: %w", kind, err) | ||
| } | ||
| if exp > MaxExponentBips { |
Contributor
Author
There was a problem hiding this comment.
@gligneul I'm not 100% sure it's a good place for this check. Probably in the following PR with implemented model it's worth to extract math into a pure function and use it to sample new base fee for all constraints at once
Contributor
There was a problem hiding this comment.
Sure, but this code is good also.
gligneul
approved these changes
Nov 14, 2025
4 tasks done
eljobe
approved these changes
Nov 24, 2025
eljobe
deleted the
precompiles-for-multi-dimensional-multi-constraint-pricer
branch
November 24, 2025 14:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes NIT-4067
Waits #3954 (temporary includes)
Depends on:
Update blockscout on new multi-dimensional pricer abi nitro-testnode#163Update multi gas pricer abis nitro-testnode#164Add ArbMultiGasConstraintsTypes.abi blockscout#205Update ArbGasInfo and ArbOwner ABIs blockscout#206