test: remove legacy nitro-testnode integration tests - #740
Open
alxdca wants to merge 1 commit into
Open
Conversation
Contributor
|
Why are these tests legacy now? Can you add something to the PR description |
Contributor
Author
Update the PR description but we currently have integrations running against both the legacy nitro-testnode and the new, much faster, litro (arbitrum-testnode). We've kept both in parallel to ensure that the new test image doesn't result in false positives/negatives but it's looking good so far. So we can remove the legacy tests for v1 but keep them on main until then. |
yahgwai
approved these changes
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nitro-testnodeintegration-test CI job while retaining the four maintained Arbitrum Testnode variants.test:integration:arbitrum-testnodetotest:integration:localand update the README instructions./configpath fallbacks from the test helpers.Why / Context
The supported integration workflow now uses
litro(arbitrum-testnode) images to run integration tests.Removing the legacy Nitro testnode path avoids maintaining duplicate CI coverage and keeps the local documentation and test helpers aligned with the supported workflow.