Skip to content

test: remove legacy nitro-testnode integration tests - #740

Open
alxdca wants to merge 1 commit into
chore/restructure-repofrom
test/remove-nitro-testnode-tests
Open

test: remove legacy nitro-testnode integration tests#740
alxdca wants to merge 1 commit into
chore/restructure-repofrom
test/remove-nitro-testnode-tests

Conversation

@alxdca

@alxdca alxdca commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Remove the legacy nitro-testnode integration-test CI job while retaining the four maintained Arbitrum Testnode variants.
  • Rename the local integration command from test:integration:arbitrum-testnode to test:integration:local and update the README instructions.
  • Remove legacy Nitro container names and /config path fallbacks from the test helpers.

Why / Context

The supported integration workflow now uses litro (arbitrum-testnode) images to run integration tests.

Removing the legacy Nitro testnode path avoids maintaining duplicate CI coverage and keeps the local documentation and test helpers aligned with the supported workflow.

@alxdca
alxdca requested review from douglance, spsjvc and yahgwai August 5, 2026 12:20
@yahgwai

yahgwai commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

Why are these tests legacy now? Can you add something to the PR description

@alxdca

alxdca commented Aug 28, 2026

Copy link
Copy Markdown
Contributor Author

Why are these tests legacy now? Can you add something to the PR description

Update the PR description but we currently have integrations running against both the legacy nitro-testnode and the new, much faster, litro (arbitrum-testnode). We've kept both in parallel to ensure that the new test image doesn't result in false positives/negatives but it's looking good so far. So we can remove the legacy tests for v1 but keep them on main until then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants