fix(cli): resolve custom orbit chains for all cli commands - #728
Closed
yahgwai wants to merge 10 commits into
Closed
fix(cli): resolve custom orbit chains for all cli commands#728yahgwai wants to merge 10 commits into
yahgwai wants to merge 10 commits into
Conversation
- Add deployProxyAdmin: deploys an OpenZeppelin ProxyAdmin on the orbit chain. - Add deployExpressLaneAuction: deploys the Timeboost ExpressLaneAuction implementation and an initialized TransparentUpgradeableProxy, given a ProxyAdmin. - Expose both as CLI commands. - Add @arbitrum/nitro-contracts ^3.2.0 as the source of the contract ABIs/bytecode.
Drop the proxyAdmin bytecode pre-flight check and its test: no other SDK deploy function validates caller-supplied contract addresses, and address format is already validated by the CLI schema. Also collapse the 12 init-arg fields into a rest-spread rather than re-listing them into the encoder.
Make findChain synthesize a minimal chain on a registry miss instead of throwing, so every CLI call site works against freshly deployed orbit chains not yet in the registry. Removes the redundant findOrDefineChain and consolidates to a single resolver.
…resolution # Conflicts: # src/deployExpressLaneAuction.ts # src/deployProxyAdmin.ts
Contributor
Author
|
Superseded by #731. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
findChainnow synthesizes a minimal chain for ids not in the registry instead of throwing, so CLIcommands work against freshly deployed orbit chains.
previously only the deploy commands and generic contract calls were covered.
findOrDefineChain, consolidating to one resolver.