Skip to content

feat: add a docker command runner helper - #685

Closed
alxdca wants to merge 1 commit into
feat/run-forge-script-utilfrom
feat/docker-command-runner
Closed

feat: add a docker command runner helper#685
alxdca wants to merge 1 commit into
feat/run-forge-script-utilfrom
feat/docker-command-runner

Conversation

@alxdca

@alxdca alxdca commented Apr 2, 2026

Copy link
Copy Markdown
Contributor
Depends on #746. This PR is part of a stack created with Aviator.

Summary

  • add a runDockerCommand helper that wraps docker run --rm
  • support passing command args, an optional entrypoint, and environment variables
  • return structured execution metadata including argv, stdout, stderr, and exit code

Why / Context

  • upcoming SDK flows need a reusable way to invoke Docker-based tooling
  • environment values should be passed to the child process without leaking secret contents into logged argv or error metadata
  • centralizing the Docker invocation logic makes higher-level Docker-backed features easier to implement and test

Test Plan

  • Run the unit test suite covering src/runDockerCommand.unit.test.ts
  • Verify the helper correctly passes env var names without exposing env var values in argv or error metadata
  • Smoke test one Docker-backed call path that uses this helper

@alxdca
alxdca force-pushed the feat/docker-command-runner branch from e567549 to 0c9dbc3 Compare April 2, 2026 12:45
@alxdca alxdca changed the title Add a docker command runner helper feat: add a docker command runner helper Apr 15, 2026
@alxdca
alxdca requested a review from spsjvc April 17, 2026 13:39
@alxdca
alxdca marked this pull request as ready for review April 17, 2026 13:39
@alxdca
alxdca force-pushed the feat/docker-command-runner branch from 0c9dbc3 to a28cf9a Compare May 4, 2026 13:27
@alxdca
alxdca force-pushed the feat/docker-command-runner branch from 3caf275 to f052dc7 Compare May 5, 2026 15:38
@alxdca
alxdca force-pushed the feat/docker-command-runner branch from f052dc7 to 74dba19 Compare August 27, 2026 09:30
@alxdca
alxdca changed the base branch from main to feat/run-forge-script-util August 27, 2026 12:17
@alxdca
alxdca force-pushed the feat/run-forge-script-util branch from 5266a24 to be2623f Compare September 1, 2026 07:52
@alxdca
alxdca force-pushed the feat/docker-command-runner branch from 74dba19 to 1e9ec3d Compare September 1, 2026 07:59
@alxdca
alxdca force-pushed the feat/docker-command-runner branch from 1e9ec3d to 255247a Compare September 1, 2026 08:38
@alxdca
alxdca force-pushed the feat/run-forge-script-util branch 2 times, most recently from fbfb4ea to fe9a289 Compare September 1, 2026 08:42
@alxdca
alxdca force-pushed the feat/docker-command-runner branch 2 times, most recently from c615711 to a6db59f Compare September 1, 2026 08:49
@alxdca
alxdca force-pushed the feat/run-forge-script-util branch from fe9a289 to 5761383 Compare September 1, 2026 08:49
@alxdca
alxdca force-pushed the feat/docker-command-runner branch from a6db59f to b3b9bf3 Compare September 1, 2026 08:53
@alxdca
alxdca force-pushed the feat/run-forge-script-util branch from 5761383 to 111eefb Compare September 1, 2026 08:54
@alxdca
alxdca force-pushed the feat/docker-command-runner branch from b3b9bf3 to 0af594a Compare September 1, 2026 08:54
@alxdca
alxdca force-pushed the feat/run-forge-script-util branch 3 times, most recently from 1c15834 to 94dd484 Compare September 1, 2026 09:01
@alxdca
alxdca force-pushed the feat/docker-command-runner branch 3 times, most recently from 2c8f265 to 1aade4e Compare September 1, 2026 09:39
@alxdca
alxdca force-pushed the feat/run-forge-script-util branch from fd8c48e to 5d44f71 Compare September 1, 2026 09:39
@alxdca
alxdca force-pushed the feat/run-forge-script-util branch from 5d44f71 to c0b71fa Compare September 1, 2026 09:42
@alxdca
alxdca force-pushed the feat/docker-command-runner branch from 1aade4e to 3860acd Compare September 1, 2026 09:42
@alxdca alxdca closed this Sep 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant