Config webpack

[Odongo006]

Hello, in this project I managed to complete the following tasks listed below : -

• Set up project with webpack.
• Create an index.js, index.html and style.css
• On page load render the dynamically created list of tasks in the dedicated placeholder.
• All source files are located in /src directory
• distribution files are generated by webpack and served by webpack dev server from /dist folder.

[emmiiorji]

Hi @Odongo006,

While you made a great effort in this project, unfortunately, I cannot proceed to review your code.

Invalid Code Review Request

You have submitted a project with without a professional documentation in a README file. Kindly utilize the readme template to create one.

You have also modified the linters configuration file.

Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready 🙏

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

---

Invalid Code Review Request does not count into the code reviews limit.

[emmiiorji]

Kindly remove this line of code. Endeavour to avoid modifying the linters configuration files

[emmiiorji]

Hi @Odongo006,

Status: Changes Required ♻️

Good job so far!
There are some issues that you still need to work on to go to the next project but you are almost there!

Good Highlights✔️

• Good commit messages
• Proper us of GitHub flow

Required Changes ♻️

Check the comments under the review.

Optional suggestions

• I suggest that you rename the repository to match the purpose of the project. This will help you and others to quickly tell what the project is about. For example todo-list instead of Config-Webpack

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

---

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

[emmiiorji]

Could you avoid disabling linter checks in line? They represent coding standards that you share with your team and most of the time enforce the best coding practices.

There are three other occurrences.

[Odongo006]

Hey @emmiiorji , do you have an idea on how to go about this?.....I've tried solving it but I've just run into endless errors.

[emmiiorji]

Hi @Odongo006

Here's what you can do to solve the issue:

Whenever you pull codes from github (and anytime you have the linebreak error), run npx eslint . --fix to change end of line sequence from 'LF' to 'CRLF'

Kindly remove the remove these two lines from the .eslintrc.json file:

[Odongo006]

Hey emmiiorji whenever I run this command npm eslint --fix it doesnt solve the error. As you can see on the screenshot, I've attached below, I've tried solving this problem using the command npm eslint --fix but still that doesn't solve the situation.

[emmiiorji]

Hi @Odongo006,

It works here without inline disabling of checks.

[Odongo006]

@emmiiorji take a look at my screenshot

[emmiiorji]

You seem to be missing a . in your command. The command is npx eslint . --fix not npx eslint --fix

[Odongo006]

@emmiiorji I appreciate your support bro, that has solved my problem.

[GzimAsani]

STATUS: APPROVED 💯

There is nothing else to say than it's time to merge... 🥳

Cheers and Happy coding! 👏 💻 🍷
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.

Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

You can also consider:

• NA

Please be reminded to not open a new pull request after you get a review, only use the same one 💭

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

_As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.