[6000.0] Fixed Custom URP Compile errors#59
Open
JessAtMeta wants to merge 1 commit into
Open
Conversation
…erenced from origin/master, wrapped packedMaterialData.isIndirectSupported with conditional compilation in InstanceCullingBatcher.cs, updated constants / keyword usage in ShaderScriptableStripperTests.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed up 6000.0 compilation; restored TraceRayAndQueryHit.hlsl as referenced from origin/master, wrapped packedMaterialData.isIndirectSupported with conditional compilation in InstanceCullingBatcher.cs, updated constants / keyword usage in ShaderScriptableStripperTests.cs
Checklist for PR maker
need-backport-*label. After you backport the PR, the label changes tobackported-*.CHANGELOG.mdfile.Purpose of this PR
Users were getting compile errors when opening projects including the following packages:
The console should be clear of errors when loading these packages.
Testing status
Creating a project and including the above packages should no longer result in an error. To test from this fork instead, use:
Comments to reviewers
This should merge into the Oculus-VR/UnityGraphics fork of Unity's graphics mono-repo