Skip to content

[6000.0] Fixed Custom URP Compile errors#59

Open
JessAtMeta wants to merge 1 commit into
Oculus-VR:6000.0/oculus-app-spacewarpfrom
JessAtMeta:6000.0/asw-fix
Open

[6000.0] Fixed Custom URP Compile errors#59
JessAtMeta wants to merge 1 commit into
Oculus-VR:6000.0/oculus-app-spacewarpfrom
JessAtMeta:6000.0/asw-fix

Conversation

@JessAtMeta

@JessAtMeta JessAtMeta commented Jul 6, 2026

Copy link
Copy Markdown

Fixed up 6000.0 compilation; restored TraceRayAndQueryHit.hlsl as referenced from origin/master, wrapped packedMaterialData.isIndirectSupported with conditional compilation in InstanceCullingBatcher.cs, updated constants / keyword usage in ShaderScriptableStripperTests.cs

Checklist for PR maker

  • Have you added a backport label (if needed)? For example, the need-backport-* label. After you backport the PR, the label changes to backported-*.
  • Have you updated the changelog? Each package has a CHANGELOG.md file.
  • Have you updated or added the documentation for your PR? When you add a new feature, change a property name, or change the behavior of a feature, it's best practice to include related documentation changes in the same PR. If you do add documentation, make sure to add the relevant Graphics Docs team member as a reviewer of the PR. If you are not sure which person to add, see the Docs team contacts sheet.
  • Have you added a graphic test for your PR (if needed)? When you add a new feature, or discover a bug that tests don't cover, please add a graphic test.

Purpose of this PR

Users were getting compile errors when opening projects including the following packages:

com.unity.render-pipelines.core@git+https://github.com/Oculus-VR/Unity-Graphics.git?path=/Packages/com.unity.render-pipelines.core#6000.0/oculus-app-spacewarp
com.unity.render-pipelines.universal@git+https://github.com/Oculus-VR/Unity-Graphics.git?path=/Packages/com.unity.render-pipelines.universal#6000.0/oculus-app-spacewarp 
com.unity.shadergraph@git+https://github.com/Oculus-VR/Unity-Graphics.git?path=/Packages/com.unity.shadergraph#6000.0/oculus-app-spacewarp

The console should be clear of errors when loading these packages.


Testing status

Creating a project and including the above packages should no longer result in an error. To test from this fork instead, use:

com.unity.render-pipelines.core@git+https://github.com/JessAtMeta/Unity-Graphics.git?path=/Packages/com.unity.render-pipelines.core#6000.0/asw-fix
com.unity.render-pipelines.universal@git+https://github.com/JessAtMeta/Unity-Graphics.git?path=/Packages/com.unity.render-pipelines.universal#6000.0/asw-fix
com.unity.shadergraph@git+https://github.com/JessAtMeta/Unity-Graphics.git?path=/Packages/com.unity.shadergraph#6000.0/asw-fix

Comments to reviewers

This should merge into the Oculus-VR/UnityGraphics fork of Unity's graphics mono-repo

…erenced from origin/master, wrapped packedMaterialData.isIndirectSupported with conditional compilation in InstanceCullingBatcher.cs, updated constants / keyword usage in ShaderScriptableStripperTests.cs
@JessAtMeta JessAtMeta marked this pull request as ready for review July 6, 2026 21:09
@JessAtMeta JessAtMeta changed the title Fixed Custom URP Compile errors [6000.0] Fixed Custom URP Compile errors Jul 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant