Skip to content

feat: Warn when OIDC build feature is missing or misconfigured#209

Merged
matt-richardson merged 4 commits into
mainfrom
feature/oidc-feature-warning
Jul 3, 2026
Merged

feat: Warn when OIDC build feature is missing or misconfigured#209
matt-richardson merged 4 commits into
mainfrom
feature/oidc-feature-warning

Conversation

@matt-richardson

@matt-richardson matt-richardson commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Background

When an OIDC connection's build feature is absent or misconfigured, %jwt.token% (or the connector's token_variable_name) never resolves and the octopus login fails at runtime with no easy diagnosis.

These warnings surface the misconfiguration while editing.

Results

Adds two advisory warnings to a build step's edit form, shown when the selected Octopus connection authenticates with OIDC but the build configuration lacks a correctly-configured OIDC Identity Token build feature (oidc-plugin, from teamcity-oidc-plugin):

  • Feature missing — the connection uses OIDC but no oidc-plugin build feature references its connector (connection_id ≠ the connection's octopus_oidc_connection_id).
  • Token variable mismatch — a matching feature exists but publishes its token under a different variable name than Octopus reads, so %<var>% never resolves.

Notes:

  • The warnings do not block a save.
  • Non-OIDC and no-connection steps are unaffected; when the SBuildType can't be resolved, no warning is shown.
  • Inline oidc-plugin features (no connection_id) are not a supported Octopus OIDC path, so warning in that case is intended.

Screenshots

image image

@matt-richardson matt-richardson changed the title Warn in step form when an OIDC connection's build feature is missing or misconfigured feat: Warn when OIDC build feature is missing or misconfigured Jul 3, 2026
@github-actions github-actions Bot added the feat label Jul 3, 2026
@matt-richardson matt-richardson self-assigned this Jul 3, 2026

@APErebus APErebus left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@matt-richardson matt-richardson merged commit 5880907 into main Jul 3, 2026
6 checks passed
@matt-richardson matt-richardson deleted the feature/oidc-feature-warning branch July 3, 2026 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants