Skip to content

fix: Remove stored inline creds on save when a connection is selected#207

Merged
matt-richardson merged 7 commits into
mainfrom
feature/blank-inline-creds-on-connection-select
Jul 2, 2026
Merged

fix: Remove stored inline creds on save when a connection is selected#207
matt-richardson merged 7 commits into
mainfrom
feature/blank-inline-creds-on-connection-select

Conversation

@matt-richardson

@matt-richardson matt-richardson commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

What

When a build step is saved with a connection selected, the inline credential parameters are are now redundant and can cause confusion when searching for usages in teamcity.

Results

This PR now clears the existing params when a connection is selected:

  • octopus_host (server URL)
  • secure:octopus_apikey (API key)
  • octopus_version

octopus_space_name is not stripped - the step can overrides the connection's value, and the PropertiesProcessor has no project context to resolve the connection's space.

@matt-richardson matt-richardson changed the title Blank inline credentials on save when a connection is selected Remove stored inline creds on save when a connection is selected Jul 2, 2026
@matt-richardson matt-richardson self-assigned this Jul 2, 2026
@matt-richardson matt-richardson changed the title Remove stored inline creds on save when a connection is selected fix: Remove stored inline creds on save when a connection is selected Jul 2, 2026
@github-actions github-actions Bot added the fix label Jul 2, 2026
@matt-richardson matt-richardson merged commit 567ca26 into main Jul 2, 2026
7 of 9 checks passed
@matt-richardson matt-richardson deleted the feature/blank-inline-creds-on-connection-select branch July 2, 2026 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants