Skip to content

Report SDK coverage and test invalid transaction inputs - #607

Merged
Macnelson9 merged 1 commit into
Octo-Protocol-org:devfrom
jiyiola396-pixel:feat/381-382-sdk-coverage-validation
Oct 19, 2026
Merged

Macnelson9 merged 1 commit into
Octo-Protocol-org:devfrom
jiyiola396-pixel:feat/381-382-sdk-coverage-validation

Conversation

@jiyiola396-pixel

Copy link
Copy Markdown

Pull Request

Summary

  • Enable Vitest V8 coverage reporting for src/lib/sdk/**, enforce minimum coverage thresholds, and upload the HTML report as a CI artifact.
  • Add transaction-builder tests covering malformed destinations and issuers, invalid payment amounts, muxed payment destinations, and the network passphrase used by signed transactions.

Related Issue

#381 and #382

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Refactor / chore

Checklist

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings or errors.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • All CI checks pass (lint, build, tests, type checks).
  • Any dependent changes have been merged and published.

Security Checklist

  • No secrets, credentials, tokens, or API keys are logged, persisted, or transmitted.
  • No sensitive data is written to logs, error messages, or telemetry.
  • Content Security Policy (CSP) remains intact and has not been weakened.
  • No new external dependencies introduce known vulnerabilities.
  • Input validation and output encoding are applied to untrusted data.
  • Authentication and authorization checks are preserved and correctly enforced.
  • No use of unsafe APIs (e.g., eval, innerHTML, dangerouslySetInnerHTML) without justification.
  • Changes have been reviewed for potential injection, XSS, CSRF, and SSRF risks.

Screenshots / Additional Context

Tests and CI were not run, and dependencies were not installed, as requested. The package manifest adds @vitest/coverage-v8; pnpm-lock.yaml was not updated because pnpm is unavailable in the environment. The frozen-lockfile CI install may need a lockfile update before it can pass.

closes #381
closes #382

Enable SDK V8 coverage reporting in CI with minimum thresholds, archive the HTML report, and expand transaction builder tests to cover invalid input and network passphrases.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@vercel

vercel Bot commented Oct 19, 2026

Copy link
Copy Markdown

@jiyiola396-pixel is attempting to deploy a commit to the paps' projects Team on Vercel.

A member of the Team first needs to authorize it.

@drips-wave

drips-wave Bot commented Oct 19, 2026

Copy link
Copy Markdown

@jiyiola396-pixel Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@Macnelson9
Macnelson9 merged commit 3dd3ac1 into Octo-Protocol-org:dev Oct 19, 2026
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tests for invalid input to the SDK transaction builders Report test coverage in CI

2 participants