Repository navigation
Octo frontend: nested modals, privacy link, signup consent, OTP aria (#524-#527) - #599
Merged
Macnelson9 merged 4 commits intoOct 19, 2026
Merged
Conversation
|
@edwina105 is attempting to deploy a commit to the paps' projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@edwina105 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
…col-org#524) Modals register on a shared stack, so Escape closes the topmost one and Tab stays inside it. Focus returns to the opener when the modal unmounts. Closes Octo-Protocol-org#524 Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
) Opens in a new tab so the payer keeps the checkout. Closes Octo-Protocol-org#525 Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
…o-Protocol-org#526) Closes Octo-Protocol-org#526 Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
…igits (Octo-Protocol-org#527) Closes Octo-Protocol-org#527 Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Octo frontend: nested modals, privacy link, signup consent, OTP aria
/privacyin a new tab (Checkout privacy notice says "See our Privacy Policy" without a link #525)aria-describedbyandaria-invalidfromOtpInputto its digits (AuthForm passes aria props that OtpInput doesn't accept #527)Closes #524
Closes #525
Closes #526
Closes #527
🤖 Generated with Claude Code