Skip to content

fix: polling overlap and stale pages, payment link stat labels, address search scope - #596

Merged
Macnelson9 merged 4 commits into
Octo-Protocol-org:devfrom
Freezyyy-arch:fix/freezyyy-arch-polling-and-search-issues-504-507
Oct 18, 2026
Merged

Macnelson9 merged 4 commits into
Octo-Protocol-org:devfrom
Freezyyy-arch:fix/freezyyy-arch-polling-and-search-issues-504-507

Conversation

@Freezyyy-arch

Copy link
Copy Markdown
Contributor

Closes #504
Closes #505
Closes #506
Closes #507

Summary

ef9973e: fix: return the load promise so usePolling's overlap guard works (#507)

The Transactions and Payment Links load callbacks fired their request chain without returning it, so pollFn awaited undefined and usePolling's in-flight guard never held. load in both pages now returns the promise chain; usePolling itself is unchanged.

221f20a: fix: ignore stale page responses so polling cannot overwrite navigation (#506)

A slow background poll for page 1 could resolve after the user paged forward and replace the rows while the pager showed page 2. Both pages' load now tags each request with a latestReq ref id (bumped by explicit loads, captured by silent polls) and drops any response that is no longer the latest.

5453549: fix: label payment link stats by what they compute (#505)

The Payment Links stats counted only the current page and averaged collected funds per paid link, but were labelled as totals and average payment. Labels in payment-links/page.tsx are now "Links on this page", "Active on this page" and "Avg. collected per paid link (this page)".

9fb8895: fix: label address search as covering loaded addresses only (#504)

Search filters only the addresses already fetched, and the list endpoint has no customer_ref parameter, so server-side search needs a backend change. AddressSearchBox now says "Search loaded addresses by customer reference" in its placeholder and aria-label, as the issue proposes for the interim.

@vercel

vercel Bot commented Oct 18, 2026

Copy link
Copy Markdown

@Freezyyy-arch is attempting to deploy a commit to the paps' projects Team on Vercel.

A member of the Team first needs to authorize it.

@drips-wave

drips-wave Bot commented Oct 18, 2026

Copy link
Copy Markdown

@Freezyyy-arch Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@Macnelson9
Macnelson9 merged commit 0158f7f into Octo-Protocol-org:dev Oct 18, 2026
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants