Repository navigation
fix: polling overlap and stale pages, payment link stat labels, address search scope - #596
Merged
Macnelson9 merged 4 commits intoOct 18, 2026
Conversation
|
@Freezyyy-arch is attempting to deploy a commit to the paps' projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@Freezyyy-arch Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #504
Closes #505
Closes #506
Closes #507
Summary
ef9973e: fix: return the load promise so usePolling's overlap guard works (#507)
The Transactions and Payment Links
loadcallbacks fired their request chain without returning it, sopollFnawaitedundefinedandusePolling's in-flight guard never held.loadin both pages now returns the promise chain;usePollingitself is unchanged.221f20a: fix: ignore stale page responses so polling cannot overwrite navigation (#506)
A slow background poll for page 1 could resolve after the user paged forward and replace the rows while the pager showed page 2. Both pages'
loadnow tags each request with alatestReqref id (bumped by explicit loads, captured by silent polls) and drops any response that is no longer the latest.5453549: fix: label payment link stats by what they compute (#505)
The Payment Links stats counted only the current page and averaged collected funds per paid link, but were labelled as totals and average payment. Labels in
payment-links/page.tsxare now "Links on this page", "Active on this page" and "Avg. collected per paid link (this page)".9fb8895: fix: label address search as covering loaded addresses only (#504)
Search filters only the addresses already fetched, and the list endpoint has no
customer_refparameter, so server-side search needs a backend change.AddressSearchBoxnow says "Search loaded addresses by customer reference" in its placeholder and aria-label, as the issue proposes for the interim.