Skip to content

fix: abort stale requests in wallet overview, dashboard home and audit log; remove misattributed audit User column - #595

Merged
Macnelson9 merged 5 commits into
Octo-Protocol-org:devfrom
Dev-makeem:fix/dev-makeem-polling-audit-issues-508-511
Oct 18, 2026
Merged

Macnelson9 merged 5 commits into
Octo-Protocol-org:devfrom
Dev-makeem:fix/dev-makeem-polling-audit-issues-508-511

Conversation

@Dev-makeem

Copy link
Copy Markdown
Contributor

Closes #508
Closes #509
Closes #510
Closes #511

Summary

5d0aad7: fix: honour the polling abort signal in the wallet overview (#508)

  • Root cause: pollFn in the wallet overview created its own AbortController, so the signal from usePolling never cancelled in-flight requests.
  • src/app/dashboard/wallets/[id]/page.tsx: pollFn now takes signal and passes it to getBalances and listRecentTransactions.

a9fca37: fix: ignore stale wallet page responses on the dashboard home (#509)

  • Root cause: the cancel function returned by loadPage was never called, so an older response could overwrite a newer page.
  • src/app/dashboard/page.tsx: loadPage keeps the previous request's cancel in a ref and calls it before starting a new load.

58e8422: fix: drop stale audit log responses after a newer search (#510)

  • Root cause: the audit page never cancelled or discarded earlier requests, so a slow "wal" response could replace "wallet" results.
  • src/app/dashboard/audit/page.tsx: load tags each request with an incrementing id ref and ignores results and errors from outdated ones.

6cbb027: fix: stop attributing every audit row to the signed-in user (#511)

  • Root cause: the User column rendered user.email (the viewer) for every row, and the API returns no actor field.
  • src/app/dashboard/audit/page.tsx: removed the User column and adjusted the empty-row colSpan.
  • Replaced the local timeAgo with the shared RelativeTime component.

@drips-wave

drips-wave Bot commented Oct 18, 2026

Copy link
Copy Markdown

@Dev-makeem Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@vercel

vercel Bot commented Oct 18, 2026

Copy link
Copy Markdown

@Dev-makeem is attempting to deploy a commit to the paps' projects Team on Vercel.

A member of the Team first needs to authorize it.

…conflicts (Simple agent)

- src/app/dashboard/page.tsx: merged [markers] — model resolved the conflict markers

Co-authored-by: Simple Agent <agent@simple.dev>
@Macnelson9
Macnelson9 merged commit fbc412b into Octo-Protocol-org:dev Oct 18, 2026
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants