Huggingface - #11
Open
OberonDixon wants to merge 2 commits into
Open
Conversation
ayesharbajwa
left a comment
ayesharbajwa
left a comment
Collaborator
There was a problem hiding this comment.
Consider adding from_local for the model ConditionedSeqNN class as well (currently just implemented for the Predictor class, but there are use cases for instantiating the model from local weights in non-prediction scenarios as well)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The core of this change is to allow for auto-loading of a model checkpoint from https://huggingface.co/OberonDixon/methylseqnet. Currently I only have one checkpoint there: Borzoi, rep0, factorized v1.0. The interface supports extending to other base models (e.g. AlphaGenome, Basenji2) and different release versions. Only the predict pipeline is impacted; train and preprocess are unchanged. There is enough test coverage that it should be detectable if code changes to the core repo break compatibility with the huggingface-released checkpoint.