Dolphin iOS: Add Simple Skylander Portal - #68
Conversation
c9d222f to
e3e71c9
Compare
|
I do know that there is other games that also uses nfc characters like Disney Infinity. Do you think it could be used for such game or others? If so wouldn’t the name be better to describe it as load figure dump (Skylanders Portal), figuring manager (skylander manager). |
|
@Spidy123222 yeah I have got another PR open (dolphin-emu/dolphin#11546) to emulate the Infinity Base - but the structure for dumps for Infinity is much different and a lot more complex, would want a separate UIAction for that with different names |
|
Since there's a bunch of commits here that have been merged upstream already, would it be OK if I merged upstream on |
|
@OatmealDome yeah of course - I'm happy with that |
e3e71c9 to
5dd38e7
Compare
|
Let me just take a bit of time to get this to only the one commit of things that are relevant - I might have missed a commit or 2 when cherry-picking |
5b5af9b to
0eb8c0c
Compare
|
This is where I want it now - not sure about the XCode auto generated changes, but can revert those where needed |
7ad7264 to
fad91a3
Compare
fad91a3 to
5f13ddf
Compare
5f13ddf to
0cd4295
Compare
|
when will this get merged man |
09f698d to
2d531f2
Compare
|
Have just force pushed this with the latest commits, and have tested locally as working on my iPhone 14 running iOS 18.6. Also have uploaded a quick demo of this here |
2d531f2 to
cba6992
Compare
With the Skylander Portal now in mainline Dolphin, I have seen a few requests come through (like here #60) to bring the functionality to Dolphin iOS, so this PR aims to implement that here. The only relevant commit is the most recent one, the rest have been cherry-picked from the main Dolphin Repo.
As a start, I haven't added the create Skylander Functionality, so users can either just use their existing Dumps or use ones they have created on Dolphin for Desktop.
I have tried to make it as simple as possible, and not clog up the UI - so Users can select to Load, Clear or Clear All. Load will load in to the next available slot (determined in the C++ code), Clear will clear the Skylander from the most recently used Slot, and Clear all will reset the portal.
If it would be better to create a Dialog Window with the full create, load and clear functionality, I can try to implement that further down the line, but for now the UIAlert is limited with what can and can't be done. Screenshots below:
Position in the Left Menu

The Alert Dialog

In Game
