Skip to content

Dolphin iOS: Add Simple Skylander Portal - #68

Merged
OatmealDome merged 1 commit into
OatmealDome:masterfrom
deReeperJosh:skylanderportal
Oct 18, 2025
Merged

Dolphin iOS: Add Simple Skylander Portal#68
OatmealDome merged 1 commit into
OatmealDome:masterfrom
deReeperJosh:skylanderportal

Conversation

@deReeperJosh

@deReeperJosh deReeperJosh commented Mar 14, 2023

Copy link
Copy Markdown
Contributor

With the Skylander Portal now in mainline Dolphin, I have seen a few requests come through (like here #60) to bring the functionality to Dolphin iOS, so this PR aims to implement that here. The only relevant commit is the most recent one, the rest have been cherry-picked from the main Dolphin Repo.

As a start, I haven't added the create Skylander Functionality, so users can either just use their existing Dumps or use ones they have created on Dolphin for Desktop.

I have tried to make it as simple as possible, and not clog up the UI - so Users can select to Load, Clear or Clear All. Load will load in to the next available slot (determined in the C++ code), Clear will clear the Skylander from the most recently used Slot, and Clear all will reset the portal.

If it would be better to create a Dialog Window with the full create, load and clear functionality, I can try to implement that further down the line, but for now the UIAlert is limited with what can and can't be done. Screenshots below:

Position in the Left Menu
IMG_0524

The Alert Dialog
IMG_0525

In Game
IMG_0526

@deReeperJosh
deReeperJosh force-pushed the skylanderportal branch 2 times, most recently from c9d222f to e3e71c9 Compare March 14, 2023 04:13
@Spidy123222

Copy link
Copy Markdown

I do know that there is other games that also uses nfc characters like Disney Infinity. Do you think it could be used for such game or others? If so wouldn’t the name be better to describe it as load figure dump (Skylanders Portal), figuring manager (skylander manager).

@deReeperJosh

Copy link
Copy Markdown
Contributor Author

@Spidy123222 yeah I have got another PR open (dolphin-emu/dolphin#11546) to emulate the Infinity Base - but the structure for dumps for Infinity is much different and a lot more complex, would want a separate UIAction for that with different names

@OatmealDome

Copy link
Copy Markdown
Owner

Since there's a bunch of commits here that have been merged upstream already, would it be OK if I merged upstream on master and have you rebase this PR?

@deReeperJosh

Copy link
Copy Markdown
Contributor Author

@OatmealDome yeah of course - I'm happy with that

@deReeperJosh

Copy link
Copy Markdown
Contributor Author

Let me just take a bit of time to get this to only the one commit of things that are relevant - I might have missed a commit or 2 when cherry-picking

@deReeperJosh
deReeperJosh force-pushed the skylanderportal branch 2 times, most recently from 5b5af9b to 0eb8c0c Compare March 14, 2023 05:54
@deReeperJosh

Copy link
Copy Markdown
Contributor Author

This is where I want it now - not sure about the XCode auto generated changes, but can revert those where needed

Comment thread Source/Core/Core/IOS/USB/Emulated/Skylander.cpp Outdated
Comment thread Source/iOS/App/DolphiniOS/UI/Emulation/EmulationiOSViewController.mm Outdated
Comment thread Source/iOS/App/DolphiniOS/UI/Emulation/EmulationiOSViewController.mm Outdated
Comment thread Source/iOS/App/DolphiniOS/UI/Emulation/EmulationiOSViewController.mm Outdated
Comment thread Source/iOS/App/DolphiniOS/UI/Emulation/EmulationiOSViewController.mm Outdated
Comment thread Source/iOS/App/DolphiniOS/UI/Emulation/EmulationiOSViewController.mm Outdated
Comment thread Source/iOS/App/DolphiniOS/UI/Emulation/EmulationiOSViewController.mm Outdated
Comment thread Source/iOS/App/DolphiniOS/UI/Emulation/EmulationiOSViewController.mm Outdated
@C4ndyF1sh

Copy link
Copy Markdown

when will this get merged man

@deReeperJosh

Copy link
Copy Markdown
Contributor Author

Have just force pushed this with the latest commits, and have tested locally as working on my iPhone 14 running iOS 18.6. Also have uploaded a quick demo of this here

@OatmealDome
OatmealDome merged commit db6fb22 into OatmealDome:master Oct 18, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants